Restore resource registries eTag [2x] #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ries. Fixes warning "Could not find value adapter for ETag component resourceRegistries".
…rceRegistries removed" This partially reverts commit b18dedb. Specifically: - This reintroduces the resourceRegistries ETag in the various caching profiles. - Adds documentation for the ETag. - Adapts the tests to expect content for the ETag. The tests will need changes though. The legacy resource registries (portal_css/kss/javascript) are definitely not supported with this revert. This is only about the "new-style" Plone 5 resource registries in `@@resourceregistry-controlpanel`.
The previous code blindly removed the last etag, assuming it was the time based resourceRegistries ETag. This is true again, after reintroducing the modernized version of this ETag, but it was not true before. Moved the two versions of the _normalize_etag function to normalize_etag in test_utils.py. Fixed it there to only remove the last component when the current year is in it.
Filename needs to be unicode there.
This comment has been minimized.
This comment has been minimized.
|
@jenkins-plone-org please run jobs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #65 which is for master