Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Black/ Py3 #69

Merged
merged 9 commits into from
Nov 30, 2020
Merged

Black/ Py3 #69

merged 9 commits into from
Nov 30, 2020

Conversation

jensens
Copy link
Sponsor Member

@jensens jensens commented Nov 28, 2020 •
edited
Loading

  • Code style black
  • Isort
  • Python 3 only (pyupgrade, remove six)
  • zcml cleanup - less conditions
  • target: 3.0.0 release
  • Plone 5.2 now uses 2.x branch

@jensens jensens requested a review from tisto November 28, 2020 13:02
@jensens jensens marked this pull request as ready for review November 28, 2020 13:02
@jensens jensens requested a review from pbauer November 28, 2020 13:28
pbauer
pbauer approved these changes Nov 28, 2020
View reviewed changes
Copy link
Sponsor Member

@pbauer pbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks fine

@jensens jensens merged commit 87d5bee into master Nov 30, 2020
@jensens jensens deleted the black-py3 branch November 30, 2020 09:04
@mauritsvanrees
Copy link
Sponsor Member

Can we please not do these kinds of big and (mostly) automatic code quality changes when there is a perfectly fine PR that is green and waiting for a review? See #65. Now I need to rebase it on master and create a second branch for merging it to 2.x. A comment on that PR would already have helped.

I can't really complain, because you follow it up with a very useful PR with improvements for plone.restapi and new cache rules, which looks like a ton of work, which I did not even review, which is very likely made easier by this QA cleanup PR, and which you started before I started my PR.

Well, that's all from October and November, so can't do anything about it now.

But what is your black configuration? When I run black on this repo I still get lots of line length changes.

@jensens
Copy link
Sponsor Member Author

jensens commented Jan 26, 2021

sorry

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pbauer pbauer pbauer approved these changes

@tisto tisto Awaiting requested review from tisto

Assignees
No one assigned
Labels
04 type: enhancement 13 prio: normal 23 status: testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jensens @mauritsvanrees @pbauer