Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add uninstall profile #142

Merged
merged 3 commits into from
Sep 12, 2024
Merged

Add uninstall profile #142

merged 3 commits into from
Sep 12, 2024

Commits on Sep 11, 2024

  1. Add uninstall profile. 

    Part of #139
    @mauritsvanrees
    mauritsvanrees committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    0dbafff View commit details
    Browse the repository at this point in the history

  2. Replace plone.app.caching import step with a post handler. 

    Removed the `plone.app.caching.txt` Generic Setup flag file that was needed by the import step.

This is part of #139
    @mauritsvanrees
    mauritsvanrees committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    399b64b View commit details
    Browse the repository at this point in the history

  3. Renamed importVarious to post_handler. 

    The previous code gave an error:

```
...
  File ".../plone/app/caching/setuphandlers.py", line 28, in importVarious
    site = context.getSite()
AttributeError: 'RequestContainer' object has no attribute 'getSite'
```

The code needed more changes when going from import step to post handler.

Since it can no longer be used as import step, anyone using this will need to change their code, so it feels safe to rename the function without leaving a backwards compatibility layer.
The import step was meant for internal use only anyway.
    @mauritsvanrees
    mauritsvanrees committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    f9cf730 View commit details
    Browse the repository at this point in the history