Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change download and images view purge path adapter registration to IDexterityContent #137

Merged
merged 2 commits into from
Feb 8, 2024

Conversation

erral
Copy link
Sponsor Member

@erral erral commented Jan 19, 2024

Fixes #136

@mister-roboto
Copy link

@erral thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

@erral
Copy link
Sponsor Member Author

erral commented Jan 19, 2024

@jenkins-plone-org please run jobs

@erral erral changed the title change adapter registration to IDexterityContent change download and images view purge path adapter registration to IDexterityContent Jan 19, 2024
Copy link
Sponsor Member

@davisagli davisagli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any test for this functionality?

@erral
Copy link
Sponsor Member Author

erral commented Jan 21, 2024

Is there any test for this functionality?

Yes there is. The previous test keeps working.

I don't know why but when running tests the created object provides the IDexteritySchema but when creating a content object in Plone it doesn't. That's why the previous tests keep working. See here:
https://github.com/plone/plone.app.caching/blob/master/plone/app/caching/tests/test_purge.py#L330

news/136.bugfix Outdated Show resolved Hide resolved
Co-authored-by: David Glick <david.glick@plone.org>
@davisagli davisagli merged commit 31efee7 into master Feb 8, 2024
7 of 11 checks passed
@davisagli davisagli deleted the erral-issue-136 branch February 8, 2024 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@@download and @@images are never purged
3 participants