Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config with default template 9615ef91 #132

Merged
merged 2 commits into from
Nov 10, 2023

Conversation

gforcada
Copy link
Sponsor Member

Remember to use [ci-skip] on the merge commit message to avoid spamming Jenkins ✨ ♻️

@mister-roboto
Copy link

@gforcada thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

@gforcada gforcada force-pushed the config-with-default-template-9615ef91 branch from 81daa83 to 52ccfba Compare October 15, 2023 17:49
@gforcada
Copy link
Sponsor Member Author

Again, disabled the circular dependency GHA due to plone/Products.CMFPlone#3859

@mauritsvanrees mauritsvanrees merged commit 35d0b05 into master Nov 10, 2023
7 of 10 checks passed
@mauritsvanrees mauritsvanrees deleted the config-with-default-template-9615ef91 branch November 10, 2023 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants