Update GHA #519
Update GHA #519
Conversation
gforcada
commented
Oct 14, 2023
•
gforcada
commented
- remove Plone 5.2
- remove Python 3.7
- add Python 3.10 and 3.11
- update the actions versions to avoid a deprecation warning
|
@gforcada thanks for creating this Pull Request and helping to improve Plone! TL;DR: Finish pushing changes, pass all other checks, then paste a comment: To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically. Happy hacking! |
gforcada
force-pushed
the
gforcada-patch-1
branch
from
af7100d
to
51b92e9
Compare
There is a warning that the are about to be deprecated.
- remove Plone 5.2 - remove Python 3.7 - add Python 3.10 and 3.11
gforcada
force-pushed
the
gforcada-patch-1
branch
from
51b92e9
to
67c8d25
Compare
|
As I'm only changing GHA and tox, we don't really need to run the Jenkins jobs. I'm merging it myself to unlock the other PRs that are currently failing 🍀 |
|
Thanks. But declaring 5.2 unsupported, even though no actual code was changed in this PR, is a breaking change: I think up until now the master branch could be used on 5.2 if you use Python 3. This is fine to change, and there is no problem to include this in Plone 6.0. But can you add a breaking news snippet and bump the version? |
|
Sorry, I missed this for so many months 😖 is it still worth adding now the breaking change news entry, or the ship already sailed? 😓 |
