Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix failing tests related to object_provides index #518

Merged
merged 9 commits into from
Oct 19, 2023
Merged

Fix failing tests related to object_provides index #518

merged 9 commits into from
Oct 19, 2023

Conversation

Akshat2Jain
Copy link
Member

@Akshat2Jain Akshat2Jain commented Oct 13, 2023 •
edited
Loading

this pr is related to #3836

@mister-roboto
Copy link

@Akshat2Jain thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

wesleybl
wesleybl requested changes Oct 13, 2023
View reviewed changes
Copy link
Member

@wesleybl wesleybl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a line in the PR description saying it needs: plone/Products.CMFPlone#3856

src/plone/api/tests/test_content.py Outdated Show resolved Hide resolved
src/plone/api/tests/test_content.py Outdated Show resolved Hide resolved
@wesleybl
Copy link
Member

@Akshat2Jain Please click on the link Plone Jenkins CI - pull-request-6.1-3.11 below and put the link this PR and the PR plone/Products.CMFPlone#3836, so that you can test them be executed with these two PR.

And in the Plone 6.0 tests, put the link to this PR and plone/Products.CMFPlone#3856

@jaroel
Copy link
Member

jaroel commented Oct 19, 2023

@jenkins-plone-org please run jobs

@jaroel
Copy link
Member

jaroel commented Oct 19, 2023

https://jenkins.plone.org/job/pull-request-6.1-3.11/336/ is running this PR + plone/Products.CMFPlone#3836

@wesleybl
Copy link
Member

wesleybl commented Oct 19, 2023 •
edited
Loading

@jaroel thanks for taking care of this!

Now we no longer have IContentish we no longer need to run the jobs from this PR together with the CMFPlone PR. I started job 6.1-3.11 with just this PR.

wesleybl
wesleybl requested changes Oct 19, 2023
View reviewed changes
news/518.bugfix Outdated Show resolved Hide resolved
src/plone/api/tests/test_content.py
Comment on lines +211 to +212
# This section check for DX compatibility. The custom DX types defined
# in plone.api are for Plone 4 compatibility.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know it's not related to this PR but seeing "Plone 4" here made me see that this test and custom type can be removed. This branch is no longer compatible with Plone 4.

This can be done in another PR of course.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wesleybl Feel free to do so after landing this.

@jaroel jaroel requested a review from wesleybl October 19, 2023 15:19
@wesleybl
Copy link
Member

@jenkins-plone-org please run jobs

wesleybl
wesleybl requested changes Oct 19, 2023
View reviewed changes
Copy link
Member

@wesleybl wesleybl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jaroel Python 3.12 tests are failing. Please update the branch with:

#514

@jaroel
Copy link
Member

jaroel commented Oct 19, 2023

@jenkins-plone-org please run jobs

@jaroel
Copy link
Member

jaroel commented Oct 19, 2023

@jaroel Python 3.12 tests are failing. Please update the branch with:

#514

Done; you are allowed to do so too, there is no need for me specifically to do it.
Thanks for pointing is out though. I figured that might be it and that these failures wouldn't be a problem.

wesleybl
wesleybl approved these changes Oct 19, 2023
View reviewed changes
Copy link
Member

@wesleybl wesleybl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wesleybl wesleybl merged commit d93c647 into master Oct 19, 2023
13 checks passed
@wesleybl wesleybl deleted the fix_number branch October 19, 2023 17:06
@wesleybl
Copy link
Member

wesleybl commented Oct 19, 2023 •
edited
Loading

@Akshat2Jain @davisagli @jaroel thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davisagli davisagli davisagli left review comments

@jaroel jaroel jaroel left review comments

@wesleybl wesleybl wesleybl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Akshat2Jain @mister-roboto @wesleybl @jaroel @davisagli