-
-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix failing tests related to object_provides index #518
Conversation
@Akshat2Jain thanks for creating this Pull Request and helping to improve Plone! TL;DR: Finish pushing changes, pass all other checks, then paste a comment:
To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically. Happy hacking! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a line in the PR description saying it needs: plone/Products.CMFPlone#3856
@Akshat2Jain Please click on the link And in the Plone 6.0 tests, put the link to this PR and plone/Products.CMFPlone#3856 |
@jenkins-plone-org please run jobs |
https://jenkins.plone.org/job/pull-request-6.1-3.11/336/ is running this PR + plone/Products.CMFPlone#3836 |
@jaroel thanks for taking care of this! Now we no longer have IContentish we no longer need to run the jobs from this PR together with the CMFPlone PR. I started job 6.1-3.11 with just this PR. |
# This section check for DX compatibility. The custom DX types defined | ||
# in plone.api are for Plone 4 compatibility. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know it's not related to this PR but seeing "Plone 4" here made me see that this test and custom type can be removed. This branch is no longer compatible with Plone 4.
This can be done in another PR of course.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@wesleybl Feel free to do so after landing this.
@jenkins-plone-org please run jobs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jenkins-plone-org please run jobs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@Akshat2Jain @davisagli @jaroel thanks! |
this pr is related to #3836