Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Config with default template #509

Closed
wants to merge 11 commits into from
Closed

Config with default template #509

wants to merge 11 commits into from

Conversation

gforcada
Copy link
Sponsor Member

It's using plone/meta#92

@mister-roboto
Copy link

@gforcada thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

@gforcada gforcada force-pushed the config-with-default-template-512e28fa branch from d0efe07 to 6fd7e30 Compare May 19, 2023 08:20
@gforcada gforcada force-pushed the config-with-default-template-512e28fa branch 2 times, most recently from 94b3ca5 to 06d8584 Compare May 19, 2023 08:34
@gforcada gforcada force-pushed the config-with-default-template-512e28fa branch from 06d8584 to 974b997 Compare May 19, 2023 08:37
mauritsvanrees
mauritsvanrees approved these changes May 19, 2023
View reviewed changes
Copy link
Sponsor Member

@mauritsvanrees mauritsvanrees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Two minor inline comments, but could be handled later as well.

.meta.toml

[tox]
envlist_lines = """
py{38,39}-plone{52}
Copy link
Sponsor Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should not test Plone 5.2 on Python 3.9. But that is already happening on current master I think, so could be handled separately.

.meta.toml Outdated Show resolved Hide resolved
@gforcada gforcada mentioned this pull request Oct 14, 2023
Merged
@gforcada
Copy link
Sponsor Member Author

Duplicated of #512

@gforcada gforcada closed this Oct 14, 2023
@gforcada gforcada deleted the config-with-default-template-512e28fa branch October 14, 2023 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mauritsvanrees mauritsvanrees mauritsvanrees approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gforcada @mister-roboto @mauritsvanrees