Show only local roles when inherit=False #416
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using
api.group.get_roles
withinherit=False
, inherited roles from group memberships are shown along with local roles from adapters. This is inconsistent with what is displayed in the ZMI'smanage_listLocalRoles
and@@sharing
. E.g. if you grant a local role toAuthenticatedUsers
it is returned byget_roles
for all other groups.Suggestion: change behavior of
get_roles
when called withinherit=False
to return only local roles for the requested group to make it consistent with ZMI and sharing tab.Alternatively there could be an additional parameter/flag to make
get_roles
return only local roles.