Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show only local roles when inherit=False #416

Merged
merged 4 commits into from
Nov 5, 2018
Merged

Conversation

tschorr
Copy link
Contributor

@tschorr tschorr commented Oct 16, 2018

When using api.group.get_roles with inherit=False, inherited roles from group memberships are shown along with local roles from adapters. This is inconsistent with what is displayed in the ZMI's manage_listLocalRoles and @@sharing. E.g. if you grant a local role to AuthenticatedUsers it is returned by get_roles for all other groups.

Suggestion: change behavior of get_roles when called with inherit=False to return only local roles for the requested group to make it consistent with ZMI and sharing tab.

Alternatively there could be an additional parameter/flag to make get_roles return only local roles.

@tschorr tschorr removed the request for review from tkimnguyen October 23, 2018 13:15
@tschorr tschorr merged commit d2bf668 into master Nov 5, 2018
@hvelarde hvelarde deleted the show_local_roles_only branch November 5, 2018 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants