fix #99 for Archetypes content

[gotcha]

suggested by pgrunewald

[gotcha]

http://jenkins.plone.org/job/pull-request-4.3/378 fails with error message related to Jenkins infrastructure.

[mauritsvanrees]

Jenkins on 4.3 says: "mr.developer: The package 'plone.api' from auto-checkout has no source information."
plone.api is not in sources.cfg in coredev 4.3, so it can't be tested with Jenkins on 4.3. On 5.0 and 5.1 you should not have this problem.

Travis fails with:

• 4.3 and 5.0: plone.app.linkintegrity not found. Weird.
• 4.2: ImportError: No module named layout.navigation.root
  I get the feeling that the Makefile does not work as expected.

[gforcada]

@gotcha would you mind rebasing your branch on top of current master? travis was fixed and improved

[jensens]

Hence there was no activity for a long time, I propose to close this PR within next two weeks. If you do not feel ok with this, please speak up and provide us a rough schedule.

[gotcha]

Am I wrong to hope it runs with 4.3 ?

[adamcheasley]

Afaict, the base buildout still extends plone 4.3:
https://github.com/plone/plone.api/blob/master/buildout.cfg#L3
So I'm assuming it should run on 4.3.

[adamcheasley]

Looks like the issue might be with jenkins though:
/tmp/hudson666004923752292000.sh: line 17: bin/jenkins-alltests: No such file or directory

[mauritsvanrees]

See my comment above, from last year. plone.api is not used anywhere in coredev 4.3, so Jenkins fails because it cannot find a source. So the Jenkins 4.3 failure can be ignored.

There is a .travis.yml though, and both the 4.3 and 5.0 tests pass there.

So all relevant tests are fine.

But are you sure all changes here are wanted? I see 78 commits and changes in 31 files. Maybe you can rebase? (Carefully...)

[gotcha]

I thought I had already rebased. Not sure what I did wrong.

Only 2 commits this time. :-)

[mauritsvanrees]

Previously you did a merge, which is an entirely different beast. I think it should have the same code as result, but a very different history. Maybe github was confused.

Anyway, much saner and smaller now, thanks.
👍 from me, ready for merge as soon as Jenkins is happy.