-
-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix #99 for Archetypes content #319
Conversation
http://jenkins.plone.org/job/pull-request-4.3/378 fails with error message related to Jenkins infrastructure. |
Jenkins on 4.3 says: "mr.developer: The package 'plone.api' from auto-checkout has no source information." Travis fails with:
|
@gotcha would you mind rebasing your branch on top of current master? travis was fixed and improved |
Hence there was no activity for a long time, I propose to close this PR within next two weeks. If you do not feel ok with this, please speak up and provide us a rough schedule. |
Am I wrong to hope it runs with 4.3 ? |
Afaict, the base buildout still extends plone 4.3: |
Looks like the issue might be with jenkins though: |
See my comment above, from last year. There is a So all relevant tests are fine. But are you sure all changes here are wanted? I see 78 commits and changes in 31 files. Maybe you can rebase? (Carefully...) |
suggested by pgrunewald
I thought I had already rebased. Not sure what I did wrong. Only 2 commits this time. :-) |
Previously you did a merge, which is an entirely different beast. I think it should have the same code as result, but a very different history. Maybe github was confused. Anyway, much saner and smaller now, thanks. |
suggested by pgrunewald