Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow to set/get registry settings from an interface #286

Merged
merged 1 commit into from
Nov 30, 2015
Merged

Allow to set/get registry settings from an interface #286

merged 1 commit into from
Nov 30, 2015

Conversation

gforcada
Copy link
Sponsor Member

Fixes:
#269

@landscape-bot
Copy link

Code Health
Repository health increased by 0.28% when pulling a59168a on registry-interface-269 into 9a840e7 on master.

adamcheasley
adamcheasley reviewed Nov 26, 2015
View reviewed changes
src/plone/api/portal.py
if isinstance(name, str):

if interface is not None:
records = registry.forInterface(interface)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This appears to be an exact copy of the code above. Would it not be better to call get_registry_record here?

Copy link
Sponsor Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was thinking on refactoring it as an external method, but calling get_registry_record sounds good as well

Copy link
Sponsor Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

@landscape-bot
Copy link

Code Health
Code quality remained the same when pulling 9a06aae on plone:registry-interface-269 into 9a840e7 on plone:master.

adamcheasley pushed a commit that referenced this pull request Nov 30, 2015
Merge pull request #286 from plone/registry-interface-269
8cc89d4 
Allow to set/get registry settings from an interface
@adamcheasley adamcheasley merged commit 8cc89d4 into master Nov 30, 2015
@adamcheasley adamcheasley deleted the registry-interface-269 branch November 30, 2015 10:06
@mauritsvanrees
Copy link
Sponsor Member

@adamcheasley When you merge a pull request, can you first check that the package is added in the checkouts.cfg of the relevant plone-coredev branch? Thanks.
I have now done that: plone/buildout.coredev@cf07d53
Sorry if I was too fast and you were just about to do that. :-)

@adamcheasley
Copy link
Contributor

No problem. I was there ready to commit, but by the time I'd hit the button, you'd already done it!
Thank you.

@mauritsvanrees
Copy link
Sponsor Member

Perfect.

@gforcada
Copy link
Sponsor Member Author

Thanks for merging!

@mauritsvanrees mauritsvanrees mentioned this pull request Sep 28, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@gforcada @landscape-bot @mauritsvanrees @adamcheasley