-
-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow to set/get registry settings from an interface #286
Conversation
|
if isinstance(name, str): | ||
|
||
if interface is not None: | ||
records = registry.forInterface(interface) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This appears to be an exact copy of the code above. Would it not be better to call get_registry_record
here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was thinking on refactoring it as an external method, but calling get_registry_record
sounds good as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done!
a59168a
to
8553804
Compare
8553804
to
9a06aae
Compare
Allow to set/get registry settings from an interface
@adamcheasley When you merge a pull request, can you first check that the package is added in the checkouts.cfg of the relevant plone-coredev branch? Thanks. |
No problem. I was there ready to commit, but by the time I'd hit the button, you'd already done it! |
Perfect. |
Thanks for merging! |
Fixes:
#269