Merge pull request #528 from samriddhi99/Issue-479-optimizing-api.con…

…tent.get_view

Issue 479: Edited api.content.get_view for increased efficiency to get views

news/479.internal

@@ -0,0 +1 @@
+Improved efficiency of view retrieval by deferring availability checks to error handling. @samriddhi99

src/plone/api/content.py

@@ -13,11 +13,13 @@
 from Products.CMFCore.WorkflowCore import WorkflowException
 from zope.component import getMultiAdapter
 from zope.component import getSiteManager
+from zope.component import ComponentLookupError
 from zope.container.interfaces import INameChooser
 from zope.globalrequest import getRequest
 from zope.interface import Interface
 from zope.interface import providedBy
 
+
 import random
 import transaction
 
@@ -523,27 +525,29 @@ def get_view(name=None, context=None, request=None):
     # available, because the __init__ of said view will contain
     # errors in client code.
 
-    # Get all available views...
-    sm = getSiteManager()
-    available_views = sm.adapters.lookupAll(
-        required=(providedBy(context), providedBy(request)),
-        provided=Interface,
-    )
-    # and get their names.
-    available_view_names = [view[0] for view in available_views]
-
-    # Raise an error if the requested view is not available.
-    if name not in available_view_names:
-        raise InvalidParameterError(
-            "Cannot find a view with name '{name}'.\n"
-            "Available views are:\n"
-            "{views}".format(
-                name=name,
-                views="\n".join(sorted(available_view_names)),
-            ),
+    try:
+        return getMultiAdapter((context, request), name=name)
+    except ComponentLookupError: 
+        #Getting all available views
+        sm = getSiteManager()
+        available_views = sm.adapters.lookupAll(
+            required=(providedBy(context), providedBy(request)),
+            provided=Interface,
         )
-    return getMultiAdapter((context, request), name=name)
-
+
+        # Check if the requested view is available
+        # by getting the names of all available views
+        available_view_names = [view[0] for view in available_views]
+        if name not in available_view_names:
+            # Raise an error if the requested view is not available.
+            raise InvalidParameterError(
+                "Cannot find a view with name '{name}'.\n"
+                "Available views are:\n"
+                "{views}".format(
+                    name=name,
+                    views="\n".join(sorted(available_view_names)),
+                ),
+            )
 
 @required_parameters("obj")
 def get_uuid(obj=None):