Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Async initialization of textareas #1309

Merged
merged 1 commit into from
Apr 21, 2023
Merged

Async initialization of textareas #1309

merged 1 commit into from
Apr 21, 2023

Conversation

petschki
Copy link
Member

This should fix TinyMCE in modals not showing up (see plone/plone.app.mosaic#528)

@petschki
fix(pat textareamimetypeselector): Async initialization of textareas.…
c6d359c 
… Fixes TinyMCE in modals not showing up (see mosaic)
@petschki petschki mentioned this pull request Apr 21, 2023
Closed
@petschki petschki changed the title Async initialization of textareas.… Async initialization of textareas Apr 21, 2023
@petschki petschki requested a review from thet April 21, 2023 11:03
thet
thet approved these changes Apr 21, 2023
View reviewed changes
Copy link
Member

@thet thet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I‌wonder if this really fixes the problem of not initialized textareas, but anyways this is just the correct way. This would make sure that the pattern initialization events are thrown correctly - not before but after the pattern has been initialized.

@petschki
Copy link
Member Author

Not sure either. But here in my browser I could not reproduce the false initialization anymore with this fix. Without it the text field was randomly missing in mosaics property overlay.

@petschki petschki merged commit cc3f4b6 into master Apr 21, 2023
@petschki petschki deleted the petschki-async-textareamimetypeselector branch April 21, 2023 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thet thet thet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@petschki @thet