Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Python 3.12 #890

Merged
merged 2 commits into from
Oct 17, 2023
Merged

Add support for Python 3.12 #890

merged 2 commits into from
Oct 17, 2023

Conversation

pbauer
Copy link
Sponsor Member

@pbauer pbauer commented Oct 4, 2023

No description provided.

@gforcada gforcada mentioned this pull request Oct 5, 2023
@gforcada gforcada changed the base branch from 6.0 to 6.1 October 5, 2023 11:29
@gforcada gforcada changed the base branch from 6.1 to 6.0 October 5, 2023 11:29
@gforcada
Copy link
Sponsor Member

gforcada commented Oct 5, 2023

@pbauer do we want to add 3.12 support to Plone 6.0 first? 🤔 the jobs I created on Jenkins are for Plone 6.1, but adding them for Plone 6.0 should not be a problem 👍🏾

@gforcada
Copy link
Sponsor Member

@pbauer robotframework-browser has already a 3.12 compatible release 🎉 I updated this PR to be on top of 6.0 branch, so we get plone.api and plone.restapi fixed master branches. This should make this PR pass 🍀

@gforcada
Copy link
Sponsor Member

@mauritsvanrees the GHA Create only instance and test with Buildout fails due to robotframework-browser having a dependency on click but click version pin is only on versions-extra.cfg.

@mauritsvanrees
Copy link
Sponsor Member

@mauritsvanrees the GHA Create only instance and test with Buildout fails due to robotframework-browser having a dependency on click but click version pin is only on versions-extra.cfg.

This is exactly the kind of problem that this test is supposed to catch: click (and its dependencies) are now pulled in by Plone (or tests), so this version should be in versions.cfg.
I will move the pin. Trying it out locally first. Takes a while, as lots of packages need to be downloaded and/or compiled on 3.12 for the first time.

In 6.1 we could choose to use just one versions file. But for 6.0 we should stick to what we have.

It is pulled on even with bare.cfg now.
@mauritsvanrees
Copy link
Sponsor Member

That worked. Let's try Jenkins for good measure.

@jenkins-plone-org please run jobs

@gforcada gforcada merged commit f004ffe into 6.0 Oct 17, 2023
20 checks passed
@gforcada gforcada deleted the python312 branch October 17, 2023 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants