Update Products.MailHost to 4.10.

[mauritsvanrees]

I saw test failures earlier when I tried it in combination with other new packages.
Now let's try it on its own.
I expect failures due to the changes here: zopefoundation/Products.MailHost#30

[mauritsvanrees]

@jenkins-plone-org please run jobs

[ale-rt]

initial_value must be str or None, not bytes when doing:

    msg = message_from_string(mails.messages[0])

means that this should be fixed by changing the line to:

    msg = message_from_string(safe_nativestring(mails.messages[0]))

right?
But probably there are some other places where we should apply this safe_nativestring.

[mauritsvanrees]

On Python 3 we can call email.message_from_bytes. I have a branch for CMFPlone ready just now that does this. But other types of fixes are needed too.

[mauritsvanrees]

CMFPlone should be fixed now. Let's check the progress:

@jenkins-plone-org please run jobs

[mauritsvanrees]

@jenkins-plone-org please run jobs

[mauritsvanrees]

All green! :-)

[ale-rt]

Great work!

[mauritsvanrees]

Note that the plone.api PR is currently being tested on Plone 5.1.

And plone/plone.app.testing#70 is failing on Travis because it is being tested there with the current coredev versions, so still the older Products.MailHost; that should be fixed automatically when we merge this. And Travis also fails because the lint jobs fail, but this has nothing to do with the PR itself. That could be fixed in a separate PR.

[mauritsvanrees]

The points from my last comment have been addressed: plone.api passes on 5.1, and plone.app.testing Travis lint tests pass.
For me, this is ready to merge.
Steps to take:

• close this coredev PR, because we do not want to change the branch names
• instead, update the Products.MailHost pin to 4.10.
• Merge all PRs mentioned in Test failures with Products.MailHost 4.10 Products.CMFPlone#3178.

Do we agree that this is ready to merge?

If so, either I or someone else could do these steps.

[ale-rt]

Do we agree that this is ready to merge?

It seems the way to go for me. I would leave this to you because you have pretty clear in mind the steps to do.
Thanks for the huge effort!

[jensens]

I would leave this to you @mauritsvanrees too.

[mauritsvanrees]

All done and merged. Thanks for the reviews!