-
-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove obsolete cfgs and bump Pillow to 3.0.0 #124
Conversation
Seems P.PortalTransforms fails due to a missing dependency on libtiff, I will look into it |
Trying again: http://jenkins.plone.org/job/pull-request-5.0/435 |
Jenkins says:
Locally it is very slightly clearer, with a
This is with a small Plone logo. Visually it looks the same to me. |
The part/changed byte is in the image file directory (IFD), see http://www.fileformat.info/format/tiff/corion.htm looks like this is related to Pillow Changes for 3.0.0 and looks like this was fixed for 3.1.0 unrelased (not sure, but sound like): |
Then let's wait for 3.1.0 or 3.0.1 and merge it when we don't have to fix a test. It's not urgent. |
digged deeper, the fix for 3.1.0 seems unrelated python-pillow/Pillow#1466 digging further this is the major change python-pillow/Pillow#1419 I suspect as source of our problems. |
Branch: refs/heads/1.3.x Date: 2015-11-20T12:23:30+01:00 Author: Godefroid Chapelle (gotcha) <gotcha@bubblenet.be> Commit: plone/Products.TinyMCE@a0f5469 fix `path` expression in `wysiwyg_support` `plone.app.z3cform` support for `collective.ckeditor` where `ckeditor_wysiwyg_support` is a view rather than a skin Files changed: M HISTORY.rst M Products/TinyMCE/skins/tinymce/wysiwyg_support.pt Repository: Products.TinyMCE Branch: refs/heads/1.3.x Date: 2015-11-20T11:31:25Z Author: Godefroid Chapelle (gotcha) <gotcha@bubblenet.be> Commit: plone/Products.TinyMCE@65cfd7f Merge pull request #124 from plone/fix_traversal fix `path` expression in `wysiwyg_support` `plone.app.z3cform` support for `collective.ckeditor` where `ckeditor_wysiwyg_support` is a view rather than a skin Files changed: M HISTORY.rst M Products/TinyMCE/skins/tinymce/wysiwyg_support.pt
current test failure seems to be a test setup problem, see plone/jenkins.plone.org#141 |
@jensens not a test setup rather a junit parser error as the error is still there. Whenever in doubt just look at the full console log: http://jenkins.plone.org/job/pull-request-5.0/695/console |
well, but how can a pillow update break the test output. strange. maybe the test is crap. |
Because the output is binary :-)
|
So I fixed the output in PortalTransforms to be able to analyse the problem. See plone/Products.PortalTransforms#11 The TIFF header (first 8 Bytes) are ok. In the following (in test output truncated) IFD headers are changed: the byte at position 13 is a Further reading: http://www.fileformat.info/format/tiff/corion.htm http://paulbourke.net/dataformats/tiff/ I propose to change PortalTransforms so it
Opinions? |
+1 |
1 similar comment
+1 |
done. |
Remove obsolete cfgs and bump Pillow to 3.0.0
Branch: refs/heads/master Date: 2017-04-10T11:44:00+03:00 Author: Asko Soukka (datakurre) <asko.soukka@iki.fi> Commit: plone/plone.app.content@060f083 Fix issue where some folder actions failed when path above had private level Files changed: M plone/app/content/browser/contents/__init__.py M plone/app/content/browser/contents/paste.py M plone/app/content/tests/test_contents.py Repository: plone.app.content Branch: refs/heads/master Date: 2017-04-10T11:44:03+03:00 Author: Asko Soukka (datakurre) <asko.soukka@iki.fi> Commit: plone/plone.app.content@6a9d6b1 Update changelog Files changed: M CHANGES.rst Repository: plone.app.content Branch: refs/heads/master Date: 2017-04-10T13:17:25+02:00 Author: Johannes Raggam (thet) <thetetet@gmail.com> Commit: plone/plone.app.content@ec3bbe1 Merge pull request #124 from plone/datakurre-restrictedTraverse Fix issue where some folder actions failed when path above had privat levels Files changed: M CHANGES.rst M plone/app/content/browser/contents/__init__.py M plone/app/content/browser/contents/paste.py M plone/app/content/tests/test_contents.py
Branch: refs/heads/master Date: 2017-06-23T20:07:44+03:00 Author: MrTango (MrTango) <md@derico.de> Commit: plone/plone.app.upgrade@790b1ae Fix upgrade step for ISocialMediaSchema Files changed: M plone/app/upgrade/v51/betas.py M plone/app/upgrade/v51/configure.zcml M plone/app/upgrade/v51/profiles/to_beta4/registry.xml Repository: plone.app.upgrade Branch: refs/heads/master Date: 2017-06-23T20:12:43+03:00 Author: MrTango (MrTango) <md@derico.de> Commit: plone/plone.app.upgrade@2a4cc67 add changelog entry Files changed: M CHANGES.rst Repository: plone.app.upgrade Branch: refs/heads/master Date: 2017-06-26T11:52:15+03:00 Author: MrTango (MrTango) <md@derico.de> Commit: plone/plone.app.upgrade@c8d8f89 remove unneeded normalization in ISocialMediaSchema upgrade Files changed: M plone/app/upgrade/v51/betas.py Repository: plone.app.upgrade Branch: refs/heads/master Date: 2017-06-27T15:25:36+02:00 Author: Jens W. Klein (jensens) <jk@kleinundpartner.at> Commit: plone/plone.app.upgrade@7d77c2f Merge pull request #124 from plone/MrTango_fix_update_social_media_fields Fix upgrade step for ISocialMediaSchema Files changed: M CHANGES.rst M plone/app/upgrade/v51/betas.py M plone/app/upgrade/v51/configure.zcml M plone/app/upgrade/v51/profiles/to_beta4/registry.xml
Branch: refs/heads/master Date: 2017-06-23T20:07:44+03:00 Author: MrTango (MrTango) <md@derico.de> Commit: plone/plone.app.upgrade@790b1ae Fix upgrade step for ISocialMediaSchema Files changed: M plone/app/upgrade/v51/betas.py M plone/app/upgrade/v51/configure.zcml M plone/app/upgrade/v51/profiles/to_beta4/registry.xml Repository: plone.app.upgrade Branch: refs/heads/master Date: 2017-06-23T20:12:43+03:00 Author: MrTango (MrTango) <md@derico.de> Commit: plone/plone.app.upgrade@2a4cc67 add changelog entry Files changed: M CHANGES.rst Repository: plone.app.upgrade Branch: refs/heads/master Date: 2017-06-26T11:52:15+03:00 Author: MrTango (MrTango) <md@derico.de> Commit: plone/plone.app.upgrade@c8d8f89 remove unneeded normalization in ISocialMediaSchema upgrade Files changed: M plone/app/upgrade/v51/betas.py Repository: plone.app.upgrade Branch: refs/heads/master Date: 2017-06-27T15:25:36+02:00 Author: Jens W. Klein (jensens) <jk@kleinundpartner.at> Commit: plone/plone.app.upgrade@7d77c2f Merge pull request #124 from plone/MrTango_fix_update_social_media_fields Fix upgrade step for ISocialMediaSchema Files changed: M CHANGES.rst M plone/app/upgrade/v51/betas.py M plone/app/upgrade/v51/configure.zcml M plone/app/upgrade/v51/profiles/to_beta4/registry.xml
Branch: refs/heads/master Date: 2019-04-08T16:35:08+02:00 Author: Jens W. Klein (jensens) <jk@kleinundpartner.at> Commit: plone/Products.Archetypes@107a89b Make QueryStringWidgetTests more robust/independent of implementation details Files changed: A news/124.bugfix M Products/Archetypes/tests/test_pawidgets.py Repository: Products.Archetypes Branch: refs/heads/master Date: 2019-04-09T09:37:30+02:00 Author: Jens W. Klein (jensens) <jk@kleinundpartner.at> Commit: plone/Products.Archetypes@5b7ca0a Merge pull request #124 from plone/jensens/more-robust-pawidgets-test Make QueryStringWidgetTests more robust/independent of implementation details Files changed: A news/124.bugfix M Products/Archetypes/tests/test_pawidgets.py
Branch: refs/heads/master Date: 2019-08-22T09:43:21+02:00 Author: tschorr (tschorr) <t_schorr@gmx.de> Commit: plone/plone.recipe.zope2instance@8b48f87 add sentry support Files changed: A src/plone/recipe/zope2instance/sentry.py M README.rst M setup.py M src/plone/recipe/zope2instance/recipe.py M src/plone/recipe/zope2instance/tests/wsgi.txt Repository: plone.recipe.zope2instance Branch: refs/heads/master Date: 2019-08-22T09:47:57+02:00 Author: tschorr (tschorr) <t_schorr@gmx.de> Commit: plone/plone.recipe.zope2instance@e176cf5 add changelog entry Files changed: A news/124.feature Repository: plone.recipe.zope2instance Branch: refs/heads/master Date: 2019-08-22T10:12:57+02:00 Author: tschorr (tschorr) <t_schorr@gmx.de> Commit: plone/plone.recipe.zope2instance@2441b21 update readme Files changed: M README.rst Repository: plone.recipe.zope2instance Branch: refs/heads/master Date: 2019-08-22T12:13:12+02:00 Author: tschorr (tschorr) <t_schorr@gmx.de> Commit: plone/plone.recipe.zope2instance@633c15e add logging options Files changed: M README.rst M src/plone/recipe/zope2instance/recipe.py M src/plone/recipe/zope2instance/sentry.py M src/plone/recipe/zope2instance/tests/wsgi.txt Repository: plone.recipe.zope2instance Branch: refs/heads/master Date: 2019-08-22T17:28:28+02:00 Author: Andreas Jung (zopyx) <info@zopyx.com> Commit: plone/plone.recipe.zope2instance@c76e817 Merge pull request #124 from plone/wsgi_sentry_support Add Sentry support Files changed: A news/124.feature A src/plone/recipe/zope2instance/sentry.py M README.rst M setup.py M src/plone/recipe/zope2instance/recipe.py M src/plone/recipe/zope2instance/tests/wsgi.txt
Branch: refs/heads/master Date: 2022-06-27T11:54:53+02:00 Author: Peter Mathis (petschki) <peter.mathis@kombinat.at> Commit: plone/plone.namedfile@f8ff13e Do not use full url in image_scales dictionary Files changed: M plone/namedfile/adapters.py M plone/namedfile/scaling.py Repository: plone.namedfile Branch: refs/heads/master Date: 2022-06-27T11:54:59+02:00 Author: Peter Mathis (petschki) <peter.mathis@kombinat.at> Commit: plone/plone.namedfile@39bbe7d add changenote Files changed: A news/123.bugfix Repository: plone.namedfile Branch: refs/heads/master Date: 2022-06-27T12:03:17+02:00 Author: Peter Mathis (petschki) <peter.mathis@kombinat.at> Commit: plone/plone.namedfile@136fa54 fix tests Files changed: M plone/namedfile/tests/test_adapters.py Repository: plone.namedfile Branch: refs/heads/master Date: 2022-06-27T14:48:19+02:00 Author: Peter Mathis (petschki) <peter.mathis@kombinat.at> Commit: plone/plone.namedfile@59db776 comment why saving scale view only Files changed: M plone/namedfile/adapters.py Repository: plone.namedfile Branch: refs/heads/master Date: 2022-06-27T14:56:29+02:00 Author: Peter Mathis (petschki) <peter.mathis@kombinat.at> Commit: plone/plone.namedfile@11aae67 check if metadata scale url starts with "http" Files changed: M plone/namedfile/scaling.py Repository: plone.namedfile Branch: refs/heads/master Date: 2022-06-27T15:47:14+02:00 Author: Maurits van Rees (mauritsvanrees) <maurits@vanrees.org> Commit: plone/plone.namedfile@d2bbbce Merge pull request #124 from plone/issue-123 Do not use full url in `image_scales` dictionary Files changed: A news/123.bugfix M plone/namedfile/adapters.py M plone/namedfile/scaling.py M plone/namedfile/tests/test_adapters.py
Branch: refs/heads/master Date: 2023-04-03T23:48:29Z Author: pre-commit-ci[bot] (pre-commit-ci[bot]) <66853113+pre-commit-ci[bot]@users.noreply.github.com> Commit: plone/plone.app.caching@d4a54be [pre-commit.ci] pre-commit autoupdate updates: - [github.com/psf/black: 23.1.0 → 23.3.0](psf/black@23.1.0...23.3.0) - [github.com/collective/zpretty: 3.0.2 → 3.0.3](collective/zpretty@3.0.2...3.0.3) - [github.com/codespell-project/codespell: v2.2.2 → v2.2.4](codespell-project/codespell@v2.2.2...v2.2.4) Files changed: M .pre-commit-config.yaml Repository: plone.app.caching Branch: refs/heads/master Date: 2023-04-04T22:59:10+02:00 Author: Gil Forcada Codinachs (gforcada) <gil.gnome@gmail.com> Commit: plone/plone.app.caching@ec2d341 chore: codespell Files changed: M plone/app/caching/operations/default.py Repository: plone.app.caching Branch: refs/heads/master Date: 2023-04-04T23:04:09+02:00 Author: Gil Forcada Codinachs (gforcada) <gil.gnome@gmail.com> Commit: plone/plone.app.caching@420c790 Merge pull request #124 from plone/pre-commit-ci-update-config [pre-commit.ci] pre-commit autoupdate Files changed: M .pre-commit-config.yaml M plone/app/caching/operations/default.py
Branch: refs/heads/master Date: 2023-05-15T12:01:45+02:00 Author: Jens W. Klein (jensens) <jk@kleinundpartner.at> Commit: plone/plone.app.querystring@d7fdfe9 Fix a circular dependency to plone.app.vocabularies Files changed: A news/fix-circular-dep-pavocabularies.bugfix A plone/app/querystring/tests/testVocabularies.py A plone/app/querystring/vocabularies.py M plone/app/querystring/configure.zcml M plone/app/querystring/queryparser.py M setup.py Repository: plone.app.querystring Branch: refs/heads/master Date: 2023-05-17T11:43:13+02:00 Author: Jens W. Klein (jensens) <jk@kleinundpartner.at> Commit: plone/plone.app.querystring@45e36c4 Merge pull request #124 from plone/fix-circular-dep-pavocabularies Fix a circular dependency to plone.app.vocabularies Files changed: A news/fix-circular-dep-pavocabularies.bugfix A plone/app/querystring/tests/testVocabularies.py A plone/app/querystring/vocabularies.py M plone/app/querystring/configure.zcml M plone/app/querystring/queryparser.py M setup.py
Branch: refs/heads/master Date: 2023-05-15T12:01:45+02:00 Author: Jens W. Klein (jensens) <jk@kleinundpartner.at> Commit: plone/plone.app.querystring@d7fdfe9 Fix a circular dependency to plone.app.vocabularies Files changed: A news/fix-circular-dep-pavocabularies.bugfix A plone/app/querystring/tests/testVocabularies.py A plone/app/querystring/vocabularies.py M plone/app/querystring/configure.zcml M plone/app/querystring/queryparser.py M setup.py Repository: plone.app.querystring Branch: refs/heads/master Date: 2023-05-17T11:43:13+02:00 Author: Jens W. Klein (jensens) <jk@kleinundpartner.at> Commit: plone/plone.app.querystring@45e36c4 Merge pull request #124 from plone/fix-circular-dep-pavocabularies Fix a circular dependency to plone.app.vocabularies Files changed: A news/fix-circular-dep-pavocabularies.bugfix A plone/app/querystring/tests/testVocabularies.py A plone/app/querystring/vocabularies.py M plone/app/querystring/configure.zcml M plone/app/querystring/queryparser.py M setup.py
Branch: refs/heads/main Date: 2023-06-04T12:55:43+02:00 Author: Philip Bauer (pbauer) <bauer@starzel.de> Commit: plone/plone.volto@0effb2a Fix unchecked checkboxes in migrate_to_volto (#124) Files changed: M src/plone/volto/browser/migrate_to_volto.pt Repository: plone.volto Branch: refs/heads/main Date: 2023-06-04T12:57:07+02:00 Author: Philip Bauer (pbauer) <bauer@starzel.de> Commit: plone/plone.volto@c93f85f add changenote Files changed: A news/124.bugfix Repository: plone.volto Branch: refs/heads/main Date: 2023-06-07T07:26:47+02:00 Author: Philip Bauer (pbauer) <bauer@starzel.de> Commit: plone/plone.volto@fd6d640 Change default values Files changed: M src/plone/volto/browser/migrate_to_volto.py Repository: plone.volto Branch: refs/heads/main Date: 2023-06-07T08:50:07+02:00 Author: Philip Bauer (pbauer) <bauer@starzel.de> Commit: plone/plone.volto@341a7b8 check checkboxes in tests Files changed: M src/plone/volto/tests/test_migrate_to_volto.py Repository: plone.volto Branch: refs/heads/main Date: 2023-06-08T06:32:01+02:00 Author: Philip Bauer (pbauer) <bauer@starzel.de> Commit: plone/plone.volto@1299639 revert fd6d640 and 341a7b8 Files changed: M src/plone/volto/browser/migrate_to_volto.py M src/plone/volto/tests/test_migrate_to_volto.py Repository: plone.volto Branch: refs/heads/main Date: 2023-06-07T23:27:41-07:00 Author: David Glick (davisagli) <david@glicksoftware.com> Commit: plone/plone.volto@2b0920d Merge pull request #125 from plone/fix_checkboxes_in_migrate_to_volto Fix unchecked checkboxes in migrate_to_volto Files changed: A news/124.bugfix M src/plone/volto/browser/migrate_to_volto.pt
Branch: refs/heads/main Date: 2023-06-04T12:55:43+02:00 Author: Philip Bauer (pbauer) <bauer@starzel.de> Commit: plone/plone.volto@0effb2a Fix unchecked checkboxes in migrate_to_volto (#124) Files changed: M src/plone/volto/browser/migrate_to_volto.pt Repository: plone.volto Branch: refs/heads/main Date: 2023-06-04T12:57:07+02:00 Author: Philip Bauer (pbauer) <bauer@starzel.de> Commit: plone/plone.volto@c93f85f add changenote Files changed: A news/124.bugfix Repository: plone.volto Branch: refs/heads/main Date: 2023-06-07T07:26:47+02:00 Author: Philip Bauer (pbauer) <bauer@starzel.de> Commit: plone/plone.volto@fd6d640 Change default values Files changed: M src/plone/volto/browser/migrate_to_volto.py Repository: plone.volto Branch: refs/heads/main Date: 2023-06-07T08:50:07+02:00 Author: Philip Bauer (pbauer) <bauer@starzel.de> Commit: plone/plone.volto@341a7b8 check checkboxes in tests Files changed: M src/plone/volto/tests/test_migrate_to_volto.py Repository: plone.volto Branch: refs/heads/main Date: 2023-06-08T06:32:01+02:00 Author: Philip Bauer (pbauer) <bauer@starzel.de> Commit: plone/plone.volto@1299639 revert fd6d640 and 341a7b8 Files changed: M src/plone/volto/browser/migrate_to_volto.py M src/plone/volto/tests/test_migrate_to_volto.py Repository: plone.volto Branch: refs/heads/main Date: 2023-06-07T23:27:41-07:00 Author: David Glick (davisagli) <david@glicksoftware.com> Commit: plone/plone.volto@2b0920d Merge pull request #125 from plone/fix_checkboxes_in_migrate_to_volto Fix unchecked checkboxes in migrate_to_volto Files changed: A news/124.bugfix M src/plone/volto/browser/migrate_to_volto.pt
Branch: refs/heads/master Date: 2024-03-11T13:34:18+01:00 Author: Maurits van Rees (mauritsvanrees) <maurits@vanrees.org> Commit: plone/plone.app.users@ac8a95b Configuring with plone/meta Files changed: A dependabot.yml A news/+meta.internal M .editorconfig M .flake8 M .github/workflows/meta.yml M .gitignore M .meta.toml M .pre-commit-config.yaml M pyproject.toml M tox.ini Repository: plone.app.users Branch: refs/heads/master Date: 2024-03-11T14:03:52+01:00 Author: Maurits van Rees (mauritsvanrees) <maurits@vanrees.org> Commit: plone/plone.app.users@09bdeaa Fix tox dependencies and circular envs. Depend on Zope. Use `constrain_package_deps = true` so the circular env does not blindly install the latest packages from PyPI. We have this in most envs already. See also plone/meta#220 Files changed: M setup.py M tox.ini Repository: plone.app.users Branch: refs/heads/master Date: 2024-03-11T14:44:37+01:00 Author: Maurits van Rees (mauritsvanrees) <maurits@vanrees.org> Commit: plone/plone.app.users@7591ed6 black and codespell Files changed: M plone/app/users/schema.py M plone/app/users/tests/base.py Repository: plone.app.users Branch: refs/heads/master Date: 2024-03-17T13:21:08+01:00 Author: Gil Forcada Codinachs (gforcada) <gil.gnome@gmail.com> Commit: plone/plone.app.users@bff94a3 Merge pull request #124 from plone/config-with-default-template-123ebc0a Config with default template 123ebc0a Files changed: A dependabot.yml A news/+meta.internal M .editorconfig M .flake8 M .github/workflows/meta.yml M .gitignore M .meta.toml M .pre-commit-config.yaml M plone/app/users/schema.py M plone/app/users/tests/base.py M pyproject.toml M setup.py M tox.ini
Branch: refs/heads/master Date: 2024-03-11T13:34:18+01:00 Author: Maurits van Rees (mauritsvanrees) <maurits@vanrees.org> Commit: plone/plone.app.users@ac8a95b Configuring with plone/meta Files changed: A dependabot.yml A news/+meta.internal M .editorconfig M .flake8 M .github/workflows/meta.yml M .gitignore M .meta.toml M .pre-commit-config.yaml M pyproject.toml M tox.ini Repository: plone.app.users Branch: refs/heads/master Date: 2024-03-11T14:03:52+01:00 Author: Maurits van Rees (mauritsvanrees) <maurits@vanrees.org> Commit: plone/plone.app.users@09bdeaa Fix tox dependencies and circular envs. Depend on Zope. Use `constrain_package_deps = true` so the circular env does not blindly install the latest packages from PyPI. We have this in most envs already. See also plone/meta#220 Files changed: M setup.py M tox.ini Repository: plone.app.users Branch: refs/heads/master Date: 2024-03-11T14:44:37+01:00 Author: Maurits van Rees (mauritsvanrees) <maurits@vanrees.org> Commit: plone/plone.app.users@7591ed6 black and codespell Files changed: M plone/app/users/schema.py M plone/app/users/tests/base.py Repository: plone.app.users Branch: refs/heads/master Date: 2024-03-17T13:21:08+01:00 Author: Gil Forcada Codinachs (gforcada) <gil.gnome@gmail.com> Commit: plone/plone.app.users@bff94a3 Merge pull request #124 from plone/config-with-default-template-123ebc0a Config with default template 123ebc0a Files changed: A dependabot.yml A news/+meta.internal M .editorconfig M .flake8 M .github/workflows/meta.yml M .gitignore M .meta.toml M .pre-commit-config.yaml M plone/app/users/schema.py M plone/app/users/tests/base.py M pyproject.toml M setup.py M tox.ini
No description provided.