Shortcut in safe_html #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@reinhardt thanks for creating this Pull Request and helping to improve Plone! TL;DR: Finish pushing changes, pass all other checks, then paste a comment: To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically. Happy hacking! |
|
@jenkins-plone-org please run jobs |
Check for signs of html or script, skip further processing if none are found. Saves processing time for lxml parsing and manipulation.
reinhardt
force-pushed
the
scrub-shortcut
branch
from
01b54a9
to
d5c91cf
Compare
|
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
|
@jenkins-plone-org please run jobs |
reinhardt
added a commit
to plone/plone.app.content
that referenced
this pull request
Aug 6, 2024
There is now a similar check inside scrub_html, see plone/Products.PortalTransforms#66
mister-roboto
pushed a commit
to plone/buildout.coredev
that referenced
this pull request
Aug 8, 2024
Branch: refs/heads/master Date: 2024-08-02T16:20:19+02:00 Author: Manuel Reinhardt (reinhardt) <reinhardt@syslab.com> Commit: plone/plone.app.content@2524e28 getVocabulary: Call scrub_html on individual items, but check for script/html first Fixes JSONDecodeError when terms contain incomplete HTML Files changed: A news/288.bugfix M plone/app/content/browser/vocabulary.py M plone/app/content/tests/test_widgets.py Repository: plone.app.content Branch: refs/heads/master Date: 2024-08-06T08:23:33+02:00 Author: Manuel Reinhardt (reinhardt) <reinhardt@syslab.com> Commit: plone/plone.app.content@6fb696a getVocabulary: Remove check for scrub_html There is now a similar check inside scrub_html, see plone/Products.PortalTransforms#66 Files changed: M plone/app/content/browser/vocabulary.py Repository: plone.app.content Branch: refs/heads/master Date: 2024-08-07T13:11:41+02:00 Author: Manuel Reinhardt (reinhardt) <reinhardt@syslab.com> Commit: plone/plone.app.content@b44635d Rename test method Co-authored-by: Maurits van Rees <maurits@vanrees.org> Files changed: M plone/app/content/tests/test_widgets.py Repository: plone.app.content Branch: refs/heads/master Date: 2024-08-08T08:47:57+02:00 Author: Manuel Reinhardt (reinhardt) <reinhardt@syslab.com> Commit: plone/plone.app.content@6c1e1f2 Extend and explain test Co-authored-by: Maurits van Rees <maurits@vanrees.org> Files changed: M plone/app/content/tests/test_widgets.py Repository: plone.app.content Branch: refs/heads/master Date: 2024-08-08T12:17:01+02:00 Author: Maurits van Rees (mauritsvanrees) <maurits@py76.be> Commit: plone/plone.app.content@0cebad3 Merge pull request #288 from plone/getVocabulary-incomplete-html getVocabulary: Call scrub_html on individual items Files changed: A news/288.bugfix M plone/app/content/browser/vocabulary.py M plone/app/content/tests/test_widgets.py
mister-roboto
pushed a commit
to plone/buildout.coredev
that referenced
this pull request
Aug 8, 2024
Branch: refs/heads/master Date: 2024-08-02T16:20:19+02:00 Author: Manuel Reinhardt (reinhardt) <reinhardt@syslab.com> Commit: plone/plone.app.content@2524e28 getVocabulary: Call scrub_html on individual items, but check for script/html first Fixes JSONDecodeError when terms contain incomplete HTML Files changed: A news/288.bugfix M plone/app/content/browser/vocabulary.py M plone/app/content/tests/test_widgets.py Repository: plone.app.content Branch: refs/heads/master Date: 2024-08-06T08:23:33+02:00 Author: Manuel Reinhardt (reinhardt) <reinhardt@syslab.com> Commit: plone/plone.app.content@6fb696a getVocabulary: Remove check for scrub_html There is now a similar check inside scrub_html, see plone/Products.PortalTransforms#66 Files changed: M plone/app/content/browser/vocabulary.py Repository: plone.app.content Branch: refs/heads/master Date: 2024-08-07T13:11:41+02:00 Author: Manuel Reinhardt (reinhardt) <reinhardt@syslab.com> Commit: plone/plone.app.content@b44635d Rename test method Co-authored-by: Maurits van Rees <maurits@vanrees.org> Files changed: M plone/app/content/tests/test_widgets.py Repository: plone.app.content Branch: refs/heads/master Date: 2024-08-08T08:47:57+02:00 Author: Manuel Reinhardt (reinhardt) <reinhardt@syslab.com> Commit: plone/plone.app.content@6c1e1f2 Extend and explain test Co-authored-by: Maurits van Rees <maurits@vanrees.org> Files changed: M plone/app/content/tests/test_widgets.py Repository: plone.app.content Branch: refs/heads/master Date: 2024-08-08T12:17:01+02:00 Author: Maurits van Rees (mauritsvanrees) <maurits@py76.be> Commit: plone/plone.app.content@0cebad3 Merge pull request #288 from plone/getVocabulary-incomplete-html getVocabulary: Call scrub_html on individual items Files changed: A news/288.bugfix M plone/app/content/browser/vocabulary.py M plone/app/content/tests/test_widgets.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check for signs of html or script, skip further processing if none are found. Saves processing time for lxml parsing and manipulation.
See also plone/plone.app.content#288