Deprecate the portal_properties tool #3645
Conversation
The tool gets most of the methods from OFS.PropertyManager. The most relevant are using internally the hasProperty method. Deprecating this should be enough to finally start removing this obsolete tool and a bunch of code that depends on that. Refs. #125
|
@ale-rt thanks for creating this Pull Request and helping to improve Plone! TL;DR: Finish pushing changes, pass all other checks, then paste a comment: To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically. Happy hacking! |
|
@jenkins-plone-org please run jobs |
|
@jenkins-plone-org please run jobs |
|
Is there a porting guide from properties_tool to the registry? It would be great to add a link on those deprecations, so one can easily follow the link and get it ported ✨ |
|
I do not think so. |
|
Please always tell in depreciation message when it will be removed, like in Plone 7 (or 6.1)... |
|
The discussion about removing portal properties dates back in 2013 and the plan was to remove it in 5.1. I would target 6.1: there is really a lot of junk code that we can drop, especially in the tests. |
|
@jenkins-plone-org please run jobs |
|
@jenkins-plone-org please run jobs |
The tool gets most of the methods from OFS.PropertyManager.
The most relevant are using internally the hasProperty method.
Deprecating this should be enough to finally start removing this obsolete tool and a bunch of code that depends on that.
Refs. #125