Fix aliased helpers #3642
Fix aliased helpers #3642
Conversation
|
@ale-rt thanks for creating this Pull Request and helping to improve Plone! TL;DR: Finish pushing changes, pass all other checks, then paste a comment: To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically. Happy hacking! |
ale@avo:~/Code/plone/projects/coredev/6.0$ ./bin/zopepy
>>> from Products.CMFPlone.utils import getAllowedSizes
<console>:1: DeprecationWarning: getAllowedSizes is deprecated. Import from plone.namedfile.utils instead (will be removed in Plone 7)
>>> from Products.CMFPlone.utils import getQuality
<console>:1: DeprecationWarning: getQuality is deprecated. Import from plone.namedfile.utils instead (will be removed in Plone 7)
>>> from Products.CMFPlone.utils import getHighPixelDensityScales
<console>:1: DeprecationWarning: getHighPixelDensityScales is deprecated. Import from plone.namedfile.utils instead (will be removed in Plone 7) |
|
@jenkins-plone-org please run jobs |
|
Test fail with: |
There was a problem hiding this comment.
LGTM. The robot tests have been failing on jenkins node 4. I could retry them to try to run on a different node, but if this error was not caught before, I don't think even passing tests will confirm it is fixed. You demonstrated it working on the console. So I'd say go ahead and merge.
|
@jenkins-plone-org please run jobs |
|
@jenkins-plone-org please run jobs |
|
Also 3.10 was successful but failed to report back (known issue). |
There was a typo, the last dot in the alias should be a column
Fixes #3641
Refs #3615