Fix issue where catalog search with path failed when path had inaccessible (private) levels #1996
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
datakurre
referenced
this pull request
Apr 7, 2017
Checked for ``AccessInactivePortalContent`` for each path in a catalog query. This solves a problem, where Editors couldn't see inactive content, even though they had the required permission on a subpath of the portal (e.g. a subsite).
datakurre
force-pushed
the
datakurre-restrictedTraverse
branch
from
01e8c46
to
4ef9bc7
Compare
datakurre
force-pushed
the
datakurre-restrictedTraverse
branch
from
4ef9bc7
to
f83bf85
Compare
…sible (private) levels
datakurre
force-pushed
the
datakurre-restrictedTraverse
branch
from
f83bf85
to
0520fc9
Compare
|
Looks good to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
restrictedTraverse from the navigation root should be used with care, because there might be inaccessible levels for the current user between the root and target.
Please, see how catalog brains do their restricted getObject by doing unrestrictedTraverse to the parent of the target and then restrictedTraverse to the target:
https://github.com/zopefoundation/Products.ZCatalog/blob/master/src/Products/ZCatalog/CatalogBrains.py#L66