Fix950 Missing personal toolbar #1009
Conversation
|
I'm investing why on my branch |
|
you need to rebase. Jenkins job will run here: http://jenkins.plone.org/job/pull-request-5.0/331/ |
|
@hvelarde I will do so in about an hour when I get home from work. |
- Add content views from right to left to options subset until personal toolbar fits on the same line as the other menus - Cleaned hideElements of duplicated selectors - Take into consideration that you could go from a width that can't fit the toolbar to a view that is even smaller. This happens when using a Samsung galaxy 10 resolution of 1280x800. On german translation both resolutions can't display fully the toolbar however on the smaller size we need to hide even more items as such moving also the content views and not only the content menus
- moveViewsToSubset now has a clearer condition name for the moving of the view to the subset - run the hideElements action when clicking on the toobar logo to expand the toolbar. If it needs to resize it will, otherwise nothing will happen
- jQuery offset returns strange results when zooming as appose to normal offsetTop which we use to calculate whether the personal toolbar is moved - Move only the views that are not already hidden avoiding thus duplications if there is more than one view to move to the more section
- Properly set the active class on the toolbar menu list item when clicking on the more link - Fixed case where the more button lost it's active class when clicking on the children content menus. - Clicking on the body now hides also the opened more sublist - Fixed a case where the more sublist remained opened even when you were clicking on the white portal-header area because the nav bar expands in height to fit the sublist even though it's black styling remains at 50px - Fixed an issue where clicking on the sublist content menus removed the active class from the more link
- Menus are now closed when switching from expanded to contracted and back - Clicking the personal bar link now closes the subset menu as well - Fixed the position of the subset menus when collapsed by removing the hardcoded value of 105px from toolbar.plone.less
|
@hvelarde I've successfully rebased and got rid of the extra commits that were doubled from my branch but even logged in and clicking on build now will not allow me to run the jenkins build at the link given by you |
…ribes better the use of the method
|
Found my way to add a build myself for this pull request. |
|
Tests passed http://jenkins.plone.org/job/pull-request-5.0/335 |
Fix950 Missing personal toolbar
|
awesome! |
Besides that single issue I've fixed several other which can be seen in the comment.
One fix is for ticket #1002 (comment)