Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove all references to "Retina" in our source code due to trademark issues #2123

Closed
hvelarde opened this issue Aug 21, 2017 · 14 comments
Closed

Remove all references to "Retina" in our source code due to trademark issues #2123

hvelarde opened this issue Aug 21, 2017 · 14 comments
Assignees
@tkimnguyen
Labels
99 tag: sprint
Milestone
Plone 5.1

Comments

@hvelarde
Copy link
Member

hvelarde commented Aug 21, 2017 •
edited
Loading

PLIP #1483 introduced a series of changes to allow scale images in plone.scale such that they will look good on devices with pixel ratios higher than 1.

The following is from the Wikipedia:

Retina Display is a brand name used by Apple for its series of IPS panel displays that have a higher pixel density than other displays. Apple has applied to register the term "Retina" as a trademark in regard to computers and mobile devices with the United States Patent and Trademark Office, Canadian Intellectual Property Office, and in Jamaica. On November 27, 2012 the US Patent and Trademark office approved Apple's application and "Retina" is now a registered trademark for computer equipment.

I suggest to remove all references to "Retina image scales" and replace it with "High DPI image scales" (or something similar) in our source code to avoid any future trademark issues:

https://github.com/plone/Products.CMFPlone/search?utf8=%E2%9C%93&q=retina

An upgrade step will be necessary.
@hvelarde hvelarde added this to the Plone 5.1 milestone Aug 21, 2017
@tkimnguyen tkimnguyen self-assigned this Aug 21, 2017
@tkimnguyen
Copy link
Sponsor Member

"high pixel density" seems good

@tkimnguyen
Copy link
Sponsor Member

tkimnguyen commented Aug 31, 2017 •
edited
Loading

  • adding deprecation warning to getRetinaScales in Products.CMFCore.utils (replacing with getHighPixelDensityScales), in plone.namedfile, plone.formwidget
  • many .po file changes (to the msgids that included the word) but left the plone.po files alone where the msgstr contained the word

Next up:

  • Should I change .rst files like ~/PloneBuilds/buildout.coredev/plips/reviews/plip1483-retina-image-scales-review-jensens.rst
  • Should I change the occurrences I've found in .map files? e.g. Products/CMFPlone/static/plone-compiled.css.map, Products/CMFPlone/static/plone-compiled.js.map, Products/CMFPlone/static/plone-compiled.min.js, Products/CMFPlone/static/plone-compiled.min.js.map, Products/CMFPlone/static/plone-logged-in-compiled.css.map, Products/CMFPlone/static/resourceregistry-compiled.css.map, etc.
  • How to update files like .min.js or .map? (just edit directly?)

@hvelarde
Copy link
Member Author

thanks for taking care of this! I have no idea how to proceed with the rest of the stuff.

tkimnguyen added a commit that referenced this issue Aug 31, 2017
@tkimnguyen
remove mention of retina as per #2123
fcf2c53
tkimnguyen added a commit that referenced this issue Aug 31, 2017
@tkimnguyen
remove mention of retina as per #2123
6f29d03
@tkimnguyen
Copy link
Sponsor Member

tkimnguyen commented Aug 31, 2017 •
edited
Loading

I have it in this branch https://github.com/plone/Products.CMFPlone/tree/tkimnguyen-no-retina and will make a similar one for plone.namedfile and plone.formwidget.namedfile then will make a WIP PR

tkimnguyen added a commit to plone/plone.namedfile that referenced this issue Aug 31, 2017
@tkimnguyen
remove mention of retina as per plone/Products.CMFPlone#2123
4d4a2e8
tkimnguyen added a commit to plone/plone.formwidget.namedfile that referenced this issue Aug 31, 2017
@tkimnguyen
remove mention of retina as per plone/Products.CMFPlone#2123
159570f
tkimnguyen added a commit to collective/plone.app.locales that referenced this issue Aug 31, 2017
@tkimnguyen
remove mention of retina as per plone/Products.CMFPlone#2123
9cb1cfc
@tkimnguyen
Copy link
Sponsor Member

OK I think I'm done... mind you I guess I should test this... just run the test cases and try it manually to see if I broke anything?

@tkimnguyen
Copy link
Sponsor Member

  • I left the .rst files in the plips/reviews folder unchanged
  • I manually changed the .map and .min.js files

This was referenced Aug 31, 2017
Merged
Merged
Merged
Merged
@tkimnguyen tkimnguyen changed the title Remove all references to "Retina" in our source code do to tramemark issues Remove all references to "Retina" in our source code due to trademark issues Aug 31, 2017
@tkimnguyen
Copy link
Sponsor Member

OK I think I initiated the Jenkins build ok for #2133...

@jensens
Copy link
Sponsor Member

jensens commented Sep 21, 2017

Jenkins is running with this at http://jenkins.plone.org/job/pull-request-5.1/497/

@pbauer
Copy link
Sponsor Member

pbauer commented Oct 8, 2017 •
edited
Loading

@tkimnguyen you missed to change some tests. I fixed them and started a jenkins-build: http://jenkins.plone.org/job/pull-request-5.1/546/
I might need to rebase the branches first though...

@pbauer
Copy link
Sponsor Member

pbauer commented Oct 8, 2017

@tkimnguyen: Tests are now green. Please rebase your branch of Products.CMFPlone and we can merge the whole thing.

jensens added a commit that referenced this issue Oct 10, 2017
@jensens
remove mention of retina as per #2123
c8a3576
jensens pushed a commit that referenced this issue Oct 10, 2017
@tkimnguyen @jensens
remove mention of retina as per #2123
bd04fe1
@jensens
Copy link
Sponsor Member

jensens commented Oct 10, 2017

I rebased (and recompiled the plone and plone-logged-in resources) and started the tests for all 4 PRs.

@tkimnguyen
Copy link
Sponsor Member

I never got around to making the PR for namedfile packages...

mister-roboto pushed a commit to plone/buildout.coredev that referenced this issue Oct 10, 2017
@jensens
[fc] Repository: plone.namedfile
856b6c2 
Branch: refs/heads/master
Date: 2017-08-31T14:55:17-05:00
Author: T. Kim Nguyen (tkimnguyen) <tkn@alumni.uwaterloo.ca>
Commit: plone/plone.namedfile@4d4a2e8

remove mention of retina as per plone/Products.CMFPlone#2123

Files changed:
M CHANGES.rst
M plone/namedfile/scaling.py
M plone/namedfile/tests/test_scaling.py
M plone/namedfile/utils/__init__.py
Repository: plone.namedfile

Branch: refs/heads/master
Date: 2017-09-21T14:09:03+02:00
Author: Jens W. Klein (jensens) <jk@kleinundpartner.at>
Commit: plone/plone.namedfile@c503d21

Merge branch 'master' into tkimnguyen-no-retina

Files changed:
M CHANGES.rst
M plone/namedfile/scaling.py
M plone/namedfile/tests/test_scaling.py
M setup.py
Repository: plone.namedfile

Branch: refs/heads/master
Date: 2017-10-08T13:11:22+02:00
Author: Philip Bauer (pbauer) <bauer@starzel.de>
Commit: plone/plone.namedfile@e06ee67

fix tests

Files changed:
M plone/namedfile/tests/test_scaling.py
Repository: plone.namedfile

Branch: refs/heads/master
Date: 2017-10-10T15:09:18+02:00
Author: Jens W. Klein (jensens) <jk@kleinundpartner.at>
Commit: plone/plone.namedfile@6a1ee06

Merge pull request #55 from plone/tkimnguyen-no-retina

Remove mention of retina

Files changed:
M CHANGES.rst
M plone/namedfile/scaling.py
M plone/namedfile/tests/test_scaling.py
M plone/namedfile/utils/__init__.py
@jensens
Copy link
Sponsor Member

jensens commented Oct 10, 2017

I merged them all.

@jensens jensens closed this as completed Oct 10, 2017
@hvelarde
Copy link
Member Author

seems we can close this now the PR are merged.

thanks to all the involved!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tkimnguyen tkimnguyen

Labels
99 tag: sprint
Projects
None yet
Milestone
Plone 5.1
Development

No branches or pull requests
4 participants
@jensens @hvelarde @pbauer @tkimnguyen