Disabling Icons and/or thumbs globally is broken

[fgrcon]

In Site control panel:

.

If visibility globally is set to never or no for anonymous users. css class icons-off or thumbs-off are generated in the body tag (plone.app.layout). Dependant on this further classes for thumbs are used to suppress those preview images.

//supress thumbs when globally turned off
.thumbs-off  img[class*='image-scalename'] {
  display: none;
}

Unfortunately these classes are named image-scalename instead of thumb-scalename. the existing names are confusing and conflict with other class names ( e.g. image-left etc. used for tinymce ...)

[fgrcon]

@thet, @jensens, ....

done !
PRS to merge:

• - fixing https://github.com/plone/Products.CMFPlone/issues/2077 plone.app.event#259
• - fixing https://github.com/plone/Products.CMFPlone/issues/2077 plone.portlet.collection#18
• - Fgrcon fix 2077 plone.app.portlets#101
• - fixing https://github.com/plone/Products.CMFPlone/issues/2077 plone.app.content#132
• - fixing https://github.com/plone/Products.CMFPlone/issues/2077 plone.app.layout#125
• - fixing https://github.com/plone/Products.CMFPlone/issues/2077 mockup#779
• - fixing https://github.com/plone/Products.CMFPlone/issues/2077 plone.app.contenttypes#412
• - fix css classes and handling for thumbs #2078 (including recompilation of plone and plone-logged-in)

http://jenkins.plone.org/job/pull-request-5.1/184 green!
includes also (trivial modifications)

• further fixes for plip 1734-attribute-renames plone.app.portlets#100
• further fixes for plip 1734-attribute-renames plone.app.contenttypes#411

[thet]

If this is merged it's better done soon because this PR touches again many repositories.

Although I hesitate to merge it.

Those image- classes are in place since more than a year now and the selectors might already be used.
AFAIK, by the image- classes were added via these and other commits - plone/plone.app.contenttypes@3cfc044

I agree that thumb- would be more appropriate but having more generic class names has also a benefit - one must just define one CSS class name and use it for any image type.

I know, that's now coming from me who was so picky about the distinction between "thumb scale" and "thumb size"....

I need some more opinions here - @jensens @gforcada

[thet]

@fgrcon ah, this is actually about fixing a bug.

Please point me to where the .thumb-off CSS is statement.

Regarding the css statement above I think it should read:

//supress thumbs when globally turned off
.thumbs-off  img[class^='thumb-'] {
  display: none;
}

instead of image-scalename just thumb- (provided the renaming is merged) plus using ^= should be more performant than *= as it only searches the beginning of an string.

[thet]

I think I understand the issue better via this comment: plone/mockup#774 (comment)

Well, I think the PR is fine and I approve it.

[thet]

All merged. Closing this issue.