Deprecate the portal_properties tool

The tool gets most of the methods from OFS.PropertyManager.

The most relevant are using internally the hasProperty method.

Deprecating this should be enough to finally start removing this
obsolete tool and a bunch of code that depends on that.

Refs. #125

Products/CMFPlone/PropertiesTool.py

@@ -19,6 +19,7 @@
 from zope.component import getUtility
 from zope.component import queryUtility
 from Products.CMFCore.interfaces import ISiteRoot
+from zope.deprecation import deprecate
 
 
 @implementer(IPropertiesTool)
@@ -106,6 +107,15 @@ def title(self):
     def smtp_server(self):
         return getUtility(IMailHost).smtp_host
 
+
+    @deprecate(
+        "The portal portal_properties tool will be removed. "
+        "Use the portal_registry instead."
+    )
+    def hasProperty(self, id):
+        return super().hasProperty(id)
+
+
 InitializeClass(PropertiesTool)
 
 
@@ -125,4 +135,12 @@ def __init__(self, id, title=''):
     manage_options = (PropertyManager.manage_options
                       + SimpleItem.manage_options)
 
+    @deprecate(
+        "The portal portal_properties tool will be removed. "
+        "Use the portal_registry instead."
+    )
+    def hasProperty(self, id):
+        return super().hasProperty(id)
+
+
 InitializeClass(SimpleItemWithProperties)

news/125.bugfix

@@ -0,0 +1 @@
+Deprecate the portal_properties tool