Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor mergedate settings and authoryear citations #605

Merged
merged 3 commits into from
Aug 6, 2017

Conversation

moewew
Copy link
Collaborator

@moewew moewew commented Aug 6, 2017

Cf. #520 (see also #148).

Currently mergedate is still slightly broken and the format between citations and bibliography differs in year labels. This refactor brings bibliography and citations in line by using the same commands and fixes most of mergedate's fixable behaviour.

We simply use \printlabeldateextra in citations, this greatly reduces clutter.

@plk plk merged commit 24f91a8 into plk:dev Aug 6, 2017
@moewew
Copy link
Collaborator Author

moewew commented Aug 6, 2017

Note that this is quite a large change. In my tests there were some differences in output compared to v3.7, but all of these were desirable as far as I can tell (and as far as I am concerned). I assume the test suite will also report different output, so that needs careful inspection.

@plk
Copy link
Owner

plk commented Aug 6, 2017

Just ran the test suite and am checking output now.

@plk
Copy link
Owner

plk commented Aug 6, 2017

First thing to note is the changed bibtex output where there seems to be repeated labelyear (from 01-introduction.tex):

screen shot 2017-08-06 at 5 00 pm

@moewew
Copy link
Collaborator Author

moewew commented Aug 6, 2017

Ah, OK I will have to have a look at BibTeX. The tests are based on labeldatesource which is much safer than just comparing labelyear and year with Biber, but I didn't think about BibTeX.

@moewew
Copy link
Collaborator Author

moewew commented Aug 6, 2017

If you can list all the other problems that arise I will have a look at those as well.

@plk
Copy link
Owner

plk commented Aug 6, 2017

The only other difference I see for the biber tests is that entries with month/day in the .bib always have this now in the bibliography - I'm not sure about this:

screen shot 2017-08-06 at 5 20 pm

Even for normal entries which are not online-style variants:

screen shot 2017-08-06 at 5 23 pm

@moewew
Copy link
Collaborator Author

moewew commented Aug 6, 2017

This is my interpretation of what mergedate should do now. Previously entries like this would only have the month in the bibliography with the default mergedate=compact (this is the documented behaviour of mergedate in 50-style-authoryear), but since we allow for days now we might as well include them.

The BibTeX problem could be solved by adding labeldatesource to the .bbl. I am currently trying to modify the .bst to do so. But I am quite clueless with .bst files, so if you have an idea...

@plk
Copy link
Owner

plk commented Aug 6, 2017

Ok, yes, I think you are right. In that case, the biber test files look good - great work, many thanks. @josephwright - you are the bibtex expert here - can you help? We really would like to fix this soon so we can release.

plk added a commit that referenced this pull request Aug 6, 2017
@moewew
Copy link
Collaborator Author

moewew commented Aug 6, 2017

My suggested changes to biblatex.bst are in #606 now. It seems to work alright, but I would really appreciate someone with experience with BST files having a look.

plk added a commit that referenced this pull request Aug 6, 2017
plk added a commit that referenced this pull request Aug 6, 2017
@plk
Copy link
Owner

plk commented Aug 6, 2017

Tests look good, I have committed the test changes and uploaded a new 3.8. Seems we are close to being able to release? I think it's fine to put in a static label[end]year value for bibtex.

@moewew
Copy link
Collaborator Author

moewew commented Aug 7, 2017

Yes, but there are a few open issues left.

Of course that is just the list of issues that caught my eye when scrolling down the tracker.
#587 and #518 can easily be deferred.

@plk
Copy link
Owner

plk commented Aug 15, 2017

@moewew, @josephwright - can we clean up the last few things soon - we really should release I think - it's a bit overdue.

@moewew
Copy link
Collaborator Author

moewew commented Aug 16, 2017

I think I could live with some of these things being deferred to the next version.
I started working on #585 and #514 and have at least a first attempt working. In #585 I would appreciate your feedback and ideally also Ulrike's response. In #514 I probably need Joseph to have a look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants