Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error reporting #28

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Error reporting #28

wants to merge 2 commits into from

Conversation

nleanba
Copy link
Collaborator

@nleanba nleanba commented Jul 12, 2024

Fixes #16 by adding a list of all transformed files with status (succesful, has_warnings, has_errors, failed).

This provides a minimal overview over the status of file transformations, actual errors and warnings are provided as comments in the ttl as before.

also consistently put / infront of filenames
@@ -1,6 +1,7 @@
export const config = {
title: "GG2RDF",
description: "The Plazi service to transform GoldenGate XML into Turtle RDF.",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Advertising this feature with so much detail in the project description seems exagerated

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Slightly, but this seemed to me the simplest way to include a link to the status file on the index page.

The only place where that description shows up is on the index page, so using it to link to internal places that are not base-GHAct features seems appropriate

@nleanba nleanba requested a review from retog July 25, 2024 15:42
@retog
Copy link
Collaborator

retog commented Jul 25, 2024

The build fails with

error: The source code is invalid, as it does not match the expected hash in the lock file.
  Specifier: https://esm.sh/linkedom@0.16.8/cached
  Lock file: /workspaces/gg2rdf/deno.lock

I don't see anything in this pull request that might cause the error. Does it work for you?

@nleanba
Copy link
Collaborator Author

nleanba commented Jul 26, 2024

The build fails with
...

At which step of the build does it fail for you? For me it builds fine.

To me the error looks like it tried to download a dependency but got a file with the wrong hash, probably a network problem or outage on the other end. As it builds fine on my machine and on github actions, I think we can ignore this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Keep track of failures
2 participants