Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove px from img attributes #496

Merged
merged 1 commit into from
Feb 24, 2023
Merged

Remove px from img attributes #496

merged 1 commit into from
Feb 24, 2023

Conversation

willeastcott
Copy link
Contributor

The img element width and height attributes should be integers without px:

https://developer.mozilla.org/en-US/docs/Web/HTML/Element/img#width

I believe most (all?) browsers handle it OK anyway, but this PR rectifies the issue anyway.

@willeastcott willeastcott merged commit afdad31 into dev Feb 24, 2023
@willeastcott willeastcott deleted the remove-px branch February 24, 2023 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants