-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dropdown UI & Error toast for Web UI #38
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not dealbreakers, but some thoughts:
It might be better to have the toast higher in the layer than the dimmed background of a modal if possible:
Also, use of ellipsis might be useful for the overflowing entries. Also, I think it might make more sense if the shown dropdown entries can be displayed outside of the modal:
The dropdown does not close when I close the modal.
Moreover, I think it will be more natural to have two separate dropdowns for address and ABI in the webhook modal:
f924a79
to
09dd9f4
Compare
5afb7e3
to
50fdbbf
Compare
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
closes #13, closes #34