Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove TextureSource from internal map when destroyed #10832

Merged
merged 2 commits into from
Aug 7, 2024

Conversation

lunarraid
Copy link
Contributor

@lunarraid lunarraid commented Aug 6, 2024

Description of change

Fix issue where TextureSource is not removed from internal map when destroyed

Resolves #10578

Pre-Merge Checklist
  • Tests passed (npm run test)

Copy link

codesandbox-ci bot commented Aug 6, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit e6b9cb5:

Sandbox Source
pixi.js-sandbox Configuration

@lunarraid lunarraid changed the title Fix issue where TextureSource is not removed from internal map when destroyed fix: Remove TextureSource from internal map when destroyed Aug 6, 2024
@Zyie Zyie changed the base branch from dev to main August 7, 2024 15:14
@Zyie Zyie added the ✅ Ready To Merge Helpful when issues are in the queue waiting to get merged. This means the PR is completed and has t label Aug 7, 2024
@Zyie Zyie added this pull request to the merge queue Aug 7, 2024
Merged via the queue into pixijs:main with commit 20740ad Aug 7, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✅ Ready To Merge Helpful when issues are in the queue waiting to get merged. This means the PR is completed and has t
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Memory Leak in Texture Destruction
2 participants