feat: add resolution to resize event parameters #10775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: add ShaderSystem#maxTextures * use gpu.device.limits.maxSampledTexturesPerShaderStage --------- Co-authored-by: Zyie <24736175+Zyie@users.noreply.github.com>
* feat: reserve texture units for batching * maxTextures instead of reservedTextures --------- Co-authored-by: Zyie <24736175+Zyie@users.noreply.github.com>
* feat: add 'min' and 'max' blend modes * Add visual tests * Fix variable name * replace webgl2 test --------- Co-authored-by: Zyie <24736175+Zyie@users.noreply.github.com>
* add a renderable GC * lint * oops * fix nineslice destroy * fix up PR * tweak times for tests * Update package.json * remove unneeded extension.add call in TextureGCSystem and RenderableGCSystem --------- Co-authored-by: Zyie <24736175+Zyie@users.noreply.github.com>
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit c3b3025:
|
dev7355608
force-pushed
the
feat/resize-event-resolution
branch
from
2e5510d
to
b538b6e
Compare
GoodBoyDigital
approved these changes
Jul 22, 2024
GoodBoyDigital
added
the
✅ Ready To Merge
Zyie
force-pushed
the
dev
branch
2 times, most recently
from
9c9b4eb
to
23656bd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
It felt like the
resolutionargument was missing here.Pre-Merge Checklist
npm run lint)npm run test)