[MRG] Load FastText models with specified encoding #1189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome, even with non-utf8 test! |
pranaydeeps
pushed a commit
to pranaydeeps/gensim
that referenced
this pull request
Mar 21, 2017
* fixes fasttext wrapper file header * allows user specified encoding for loading fasttext models, corresponding tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to discussion in #1176
Allows user to specify a custom encoding themselves, since the FastText model file does not contain any encoding information, and FastText can create files with non-utf8 encodings in practice.
In the future, in case FastText decides to enforce utf8 (as mentioned in the readme), we may want to remove this parameter.
Also updates the header in the fasttext wrapper file.