Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Note added to annoytutorial.ipynb #1137

Merged
merged 5 commits into from
Feb 16, 2017
Merged

Note added to annoytutorial.ipynb #1137

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
2901206
Adding a note to annoytutorial.ipynb
greninja Feb 5, 2017
dbde461
Changed few words in annoytutorial.ipynb
greninja Feb 5, 2017
e6943fc
Changed the description
greninja Feb 6, 2017
af10e20
Removed the misleading initial note
greninja Feb 8, 2017
974341a
Adding link to the scipy docs for details
greninja Feb 13, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/notebooks/annoytutorial.ipynb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,7 +179,7 @@
"\n",
">**Note**: Initialization time for the annoy indexer was not included in the times. The optimal knn algorithm for you to use will depend on how many queries you need to make and the size of the corpus. If you are making very few similarity queries, the time taken to initialize the annoy indexer will be longer than the time it would take the brute force method to retrieve results. If you are making many queries however, the time it takes to initialize the annoy indexer will be made up for by the incredibly fast retrieval times for queries once the indexer has been initialized\n",
"\n",
">**Note** : **If you are using gensim, it'll run on multiple cores**. Gensim's 'most_similar' method is using numpy operations in the form of dot product whereas Annoy's method isnt. If 'numpy' on your machine is using one of the BLAS libraries like ATLAS or LAPACK, it'll run on multiple cores(only if your machine has multicore support ). "
">**Note** : Gensim's 'most_similar' method is using numpy operations in the form of dot product whereas Annoy's method isnt. If 'numpy' on your machine is using one of the BLAS libraries like ATLAS or LAPACK, it'll run on multiple cores(only if your machine has multicore support ). "
Copy link
Owner

@piskvorky piskvorky Mar 3, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isnt => isn't

LAPACK is not BLAS.

cores(only => cores (only

support ). => support).

@tmylk , did you review before merging?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree that there is a comma missing before "or LAPACK", CC @greninja

Copy link
Owner

@piskvorky piskvorky Mar 3, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What comma? LAPACK is not a BLAS library, neither software uses LAPACK.

Maybe you meant OpenBlas?

]
},
{
Expand Down