-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix OSX 14.0 Deprecated Types #535
Conversation
discoverySessionWithDeviceTypes: refAllTypes | ||
mediaType: _mediaType | ||
position: AVCaptureDevicePositionUnspecified]; | ||
discoverySessionWithDeviceTypes: refAllTypes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
xcode formatter did this
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know!. |
…s still decently readable
Seems failing on MacOS 12
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Congrats on your first contribution to mediadevices!!
Deprecated types documentation I referenced:
https://developer.apple.com/documentation/avfoundation/avcapturedevicetypebuiltinmicrophone
https://developer.apple.com/documentation/avfoundation/avcapturedevicetypeexternalunknown