Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for preventing close of stopRead nil channel #458

Merged
merged 2 commits into from
Dec 19, 2022

Conversation

malykhin
Copy link
Contributor

@malykhin malykhin commented Dec 19, 2022

Description

The behaviour is described here: #457
The issue is opened for Windows, but it occurs on Raspbian as well. Can't reproduce it on macOS.
Noticed this issue after migrating mediadevices from v0.3.7 to v0.3.10

Reference issue

Fixes #457

@codecov
Copy link

codecov bot commented Dec 19, 2022

Codecov Report

Base: 58.15% // Head: 58.16% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (d6925fd) compared to base (cb23f1f).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #458      +/-   ##
==========================================
+ Coverage   58.15%   58.16%   +0.01%     
==========================================
  Files          62       62              
  Lines        3680     3679       -1     
==========================================
  Hits         2140     2140              
+ Misses       1413     1412       -1     
  Partials      127      127              
Impacted Files Coverage Δ
track.go 25.31% <0.00%> (+0.07%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@wdouglass wdouglass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a positive change, Thanks! Would you also move the creation of stopRead from line 229 up above line 185? that way it won't be null in the first place...

@kevmo314 kevmo314 merged commit 73a158d into pion:master Dec 19, 2022
@malykhin malykhin deleted the bugfix/prevent_close_on_nil_stopRead branch December 19, 2022 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Closing media track causes panic
3 participants