Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix opus codec panic on read after close #440

Merged
merged 1 commit into from
Aug 24, 2022

Conversation

at-wat
Copy link
Member

@at-wat at-wat commented Aug 24, 2022

Also add test to other codecs

Also add test to other codecs
@at-wat at-wat self-assigned this Aug 24, 2022
@codecov
Copy link

codecov bot commented Aug 24, 2022

Codecov Report

Merging #440 (ec4a647) into master (8ad810e) will increase coverage by 0.19%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #440      +/-   ##
==========================================
+ Coverage   47.61%   47.81%   +0.19%     
==========================================
  Files          67       67              
  Lines        4469     4476       +7     
==========================================
+ Hits         2128     2140      +12     
+ Misses       2214     2209       -5     
  Partials      127      127              
Impacted Files Coverage Δ
pkg/codec/opus/opus.go 67.74% <100.00%> (+2.62%) ⬆️
pkg/codec/vpx/vpx.go 83.51% <0.00%> (+0.53%) ⬆️
track.go 25.23% <0.00%> (+0.63%) ⬆️
pkg/codec/x264/x264.go 65.11% <0.00%> (+1.16%) ⬆️
pkg/codec/openh264/openh264.go 81.15% <0.00%> (+1.44%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@edaniels edaniels merged commit 58dc90d into master Aug 24, 2022
@edaniels edaniels deleted the fix-opus-panic-on-read-after-close branch August 24, 2022 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants