Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add level and levelVal propreties to browser logger #419

Merged
merged 1 commit into from
May 27, 2018
Merged

Add level and levelVal propreties to browser logger #419

merged 1 commit into from
May 27, 2018

Conversation

slavasitnikov
Copy link
Contributor

Closes #418

davidmarkclements
davidmarkclements approved these changes May 27, 2018
View reviewed changes
Copy link
Member

@davidmarkclements davidmarkclements left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Great work

jsumners
jsumners approved these changes May 27, 2018
View reviewed changes
Copy link
Member

@jsumners jsumners left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mcollina
mcollina approved these changes May 27, 2018
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mcollina mcollina merged commit 3b1645e into pinojs:master May 27, 2018
@mcollina
Copy link
Member

Thanks @slavasitnikov!

@slavasitnikov slavasitnikov mentioned this pull request May 29, 2018
Merged
This was referenced Sep 19, 2019
Open
Open
Open
@snyk-bot snyk-bot mentioned this pull request Oct 2, 2019
Open
@github-actions
Copy link

github-actions bot commented Feb 7, 2022

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mcollina mcollina mcollina approved these changes

@jsumners jsumners jsumners approved these changes

@davidmarkclements davidmarkclements davidmarkclements approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: level prop in browser doesn't work
4 participants
@slavasitnikov @mcollina @jsumners @davidmarkclements