Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support new provider, retry and fail_expired_id properties in verify_policy configuration. #888

Merged
merged 3 commits into from
Aug 2, 2024

Conversation

mjspi
Copy link
Contributor

@mjspi mjspi commented Jul 5, 2024

Change Description

Added properties to the liveness and government_id configurations in pingone_verify_policy.

  • resource/pingone_verify_policy: Added support for the fail_expired_id, provider_auto, provider_manual, and retry_attempts properties.
  • data_source/pingone_verify_policy: Added support for the fail_expired_id, provider_auto, provider_manual, and retry_attempts properties.

Required SDK Upgrades

Dependent on SDK enhancement in PR369.

  • github.com/patrickcping/pingone-go-sdk-v2/verify v0.6.1

Testing Shell Command

TF_LOG=INFO TF_LOG_PATH=`pwd`/output.log TF_ACC=1 go test -v -timeout 240s  github.com/pingidentity/terraform-provider-pingone/internal/service/verify

Testing Results

Expand Results
=== RUN   TestAccVerifyPoliciesDataSource_NoFilter
=== PAUSE TestAccVerifyPoliciesDataSource_NoFilter
=== RUN   TestAccVerifyPolicyDataSource_All
=== PAUSE TestAccVerifyPolicyDataSource_All
=== RUN   TestAccVerifyPolicyDataSource_FailureChecks
=== PAUSE TestAccVerifyPolicyDataSource_FailureChecks
=== RUN   TestAccVerifyVoicePhraseContentDataSource_All
=== PAUSE TestAccVerifyVoicePhraseContentDataSource_All
=== RUN   TestAccVerifyVoicePhraseContentDataSource_FailureChecks
=== PAUSE TestAccVerifyVoicePhraseContentDataSource_FailureChecks
=== RUN   TestAccVerifyVoicePhraseContentsDataSource_NoFilter
=== PAUSE TestAccVerifyVoicePhraseContentsDataSource_NoFilter
=== RUN   TestAccVerifyVoicePhraseDataSource_All
=== PAUSE TestAccVerifyVoicePhraseDataSource_All
=== RUN   TestAccVerifyVoicePhraseDataSource_FailureChecks
=== PAUSE TestAccVerifyVoicePhraseDataSource_FailureChecks
=== RUN   TestAccVerifyPolicy_RemovalDrift
=== PAUSE TestAccVerifyPolicy_RemovalDrift
=== RUN   TestAccVerifyPolicy_NewEnv
=== PAUSE TestAccVerifyPolicy_NewEnv
=== RUN   TestAccVerifyPolicy_Full
=== PAUSE TestAccVerifyPolicy_Full
=== RUN   TestAccVerifyPolicy_ValidationChecks
=== PAUSE TestAccVerifyPolicy_ValidationChecks
=== RUN   TestAccVerifyPolicy_BadParameters
=== PAUSE TestAccVerifyPolicy_BadParameters
=== RUN   TestAccVerifyVoicePhraseContent_RemovalDrift
=== PAUSE TestAccVerifyVoicePhraseContent_RemovalDrift
=== RUN   TestAccVerifyVoicePhraseContent_NewEnv
=== PAUSE TestAccVerifyVoicePhraseContent_NewEnv
=== RUN   TestAccVerifyVoicePhraseContent_Full
=== PAUSE TestAccVerifyVoicePhraseContent_Full
=== RUN   TestAccVerifyVoicePhraseContent_BadParameters
=== PAUSE TestAccVerifyVoicePhraseContent_BadParameters
=== RUN   TestAccVerifyVoicePhrase_RemovalDrift
=== PAUSE TestAccVerifyVoicePhrase_RemovalDrift
=== RUN   TestAccVerifyVoicePhrase_NewEnv
=== PAUSE TestAccVerifyVoicePhrase_NewEnv
=== RUN   TestAccVerifyVoicePhrase_Full
=== PAUSE TestAccVerifyVoicePhrase_Full
=== RUN   TestAccVerifyVoicePhrase_BadParameters
=== PAUSE TestAccVerifyVoicePhrase_BadParameters
=== CONT  TestAccVerifyPoliciesDataSource_NoFilter
=== CONT  TestAccVerifyVoicePhraseContent_BadParameters
=== CONT  TestAccVerifyPolicy_BadParameters
=== CONT  TestAccVerifyVoicePhraseContent_NewEnv
=== CONT  TestAccVerifyVoicePhrase_Full
=== CONT  TestAccVerifyVoicePhrase_NewEnv
=== CONT  TestAccVerifyPolicy_Full
=== CONT  TestAccVerifyVoicePhrase_RemovalDrift
=== CONT  TestAccVerifyPolicy_ValidationChecks
=== CONT  TestAccVerifyVoicePhraseContent_RemovalDrift
--- PASS: TestAccVerifyPolicy_ValidationChecks (0.74s)
=== CONT  TestAccVerifyVoicePhrase_BadParameters
--- PASS: TestAccVerifyVoicePhrase_BadParameters (5.32s)
=== CONT  TestAccVerifyVoicePhraseContentsDataSource_NoFilter
--- PASS: TestAccVerifyVoicePhraseContent_BadParameters (6.17s)
=== CONT  TestAccVerifyPolicy_NewEnv
--- PASS: TestAccVerifyPolicy_BadParameters (7.79s)
=== CONT  TestAccVerifyPolicy_RemovalDrift
--- PASS: TestAccVerifyVoicePhrase_Full (16.40s)
=== CONT  TestAccVerifyVoicePhraseDataSource_FailureChecks
--- PASS: TestAccVerifyVoicePhraseDataSource_FailureChecks (1.18s)
=== CONT  TestAccVerifyVoicePhraseDataSource_All
--- PASS: TestAccVerifyPolicy_Full (20.57s)
=== CONT  TestAccVerifyVoicePhraseContentDataSource_All
--- PASS: TestAccVerifyVoicePhraseDataSource_All (8.89s)
=== CONT  TestAccVerifyVoicePhraseContentDataSource_FailureChecks
--- PASS: TestAccVerifyVoicePhrase_NewEnv (39.57s)
=== CONT  TestAccVerifyPolicyDataSource_FailureChecks
--- PASS: TestAccVerifyVoicePhraseContent_NewEnv (39.62s)
=== CONT  TestAccVerifyPolicyDataSource_All
--- PASS: TestAccVerifyVoicePhrase_RemovalDrift (40.85s)
=== CONT  TestAccVerifyVoicePhraseContent_Full
--- PASS: TestAccVerifyPoliciesDataSource_NoFilter (42.62s)
--- PASS: TestAccVerifyVoicePhraseContent_RemovalDrift (44.94s)
--- PASS: TestAccVerifyPolicy_NewEnv (39.31s)
--- PASS: TestAccVerifyVoicePhraseContentsDataSource_NoFilter (42.23s)
--- PASS: TestAccVerifyPolicy_RemovalDrift (42.67s)
--- PASS: TestAccVerifyVoicePhraseContent_Full (20.56s)
--- PASS: TestAccVerifyVoicePhraseContentDataSource_FailureChecks (35.70s)
--- PASS: TestAccVerifyVoicePhraseContentDataSource_All (42.14s)
--- PASS: TestAccVerifyPolicyDataSource_FailureChecks (38.80s)
--- PASS: TestAccVerifyPolicyDataSource_All (126.05s)
PASS
ok      github.com/pingidentity/terraform-provider-pingone/internal/service/verify      166.226s

@mjspi mjspi changed the title Added properties to government_id and liveness configuration objects. Support new provider, retry and fail_expired_id properties in verify_policy configuration. Jul 6, 2024
@mjspi mjspi self-assigned this Jul 6, 2024
@mjspi mjspi added service/verify PingOne Verify status/blocked/upstream-sdk The issue/PR is blocked by an upstream SDK size/medium Medium size change (e.g. enhancing the logic of an existing resource or datasource) labels Jul 6, 2024
@mjspi mjspi marked this pull request as ready for review July 6, 2024 00:13
@mjspi mjspi requested review from a team and patrickcping as code owners July 6, 2024 00:13
@patrickcping patrickcping modified the milestones: v1.0.0, v1.1.0 Jul 8, 2024
@patrickcping patrickcping removed the status/blocked/upstream-sdk The issue/PR is blocked by an upstream SDK label Aug 2, 2024
Copy link
Collaborator

@patrickcping patrickcping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀 🚀

@patrickcping patrickcping merged commit 7ed5868 into main Aug 2, 2024
14 checks passed
@patrickcping patrickcping deleted the 805-government-id-and-liveness-property-updates branch August 2, 2024 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
service/verify PingOne Verify size/medium Medium size change (e.g. enhancing the logic of an existing resource or datasource)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support new provider, retry and fail_expired_id properties in verify_policy configuration.
2 participants