Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expression: make sysdate unfoldable (#7838) #7895

Merged
merged 1 commit into from
Oct 15, 2018
Merged

expression: make sysdate unfoldable (#7838) #7895

merged 1 commit into from
Oct 15, 2018

Conversation

zz-jason
Copy link
Member

What problem does this PR solve?

cherry pick #7838 to release 2.1

What is changed and how it works?

Check List

Tests

  • Unit test

Code changes

  • Has exported function/method change

Related changes

  • Need to be included in the release note

@zz-jason
Copy link
Member Author

@winkyao @eurekaka PTAL

@zz-jason
Copy link
Member Author

/run-all-tests

alivxxx
alivxxx reviewed Oct 15, 2018
View reviewed changes
Copy link
Contributor

@alivxxx alivxxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

eurekaka
eurekaka approved these changes Oct 15, 2018
View reviewed changes
Copy link
Contributor

@eurekaka eurekaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eurekaka eurekaka added the status/LGT2 Indicates that a PR has LGTM 2. label Oct 15, 2018
@zz-jason zz-jason merged commit 8fae90e into pingcap:release-2.1 Oct 15, 2018
@zz-jason zz-jason deleted the cherrypick/2.1/7838 branch October 15, 2018 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alivxxx alivxxx alivxxx left review comments

@eurekaka eurekaka eurekaka approved these changes

Assignees
No one assigned
Labels
component/expression status/LGT2 Indicates that a PR has LGTM 2. type/bug-fix This PR fixes a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zz-jason @eurekaka @alivxxx