Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cpu and traffic into performance overview #18698

Merged

Conversation

dbsid
Copy link
Contributor

@dbsid dbsid commented Aug 24, 2024

fix #18697

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v8.4 (TiDB 8.4 versions)
  • v8.3 (TiDB 8.3 versions)
  • v8.2 (TiDB 8.2 versions)
  • v8.1 (TiDB 8.1 versions)
  • v8.0 (TiDB 8.0 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot bot added contribution This PR is from a community contributor. needs-ok-to-test labels Aug 24, 2024
Copy link

ti-chi-bot bot commented Aug 24, 2024

Hi @dbsid. Thanks for your PR.

I'm waiting for a pingcap member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added missing-translation-status This PR does not have translation status info. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 24, 2024
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 24, 2024
@dbsid dbsid changed the title Add cpu traffic into performance overview Add cpu and traffic into performance overview Aug 26, 2024
@qiancai qiancai self-requested a review August 29, 2024 07:36
@qiancai qiancai self-assigned this Aug 29, 2024
@qiancai qiancai added the translation/doing This PR's assignee is translating this PR. label Aug 29, 2024
@ti-chi-bot ti-chi-bot bot removed the missing-translation-status This PR does not have translation status info. label Aug 29, 2024
@qiancai qiancai added the needs-cherry-pick-release-8.3 Should cherry pick this PR to release-8.3 branch. label Aug 29, 2024
@qiancai
Copy link
Collaborator

qiancai commented Aug 29, 2024

Hi @dbsid, would you please involve a tech reviewer for this PR? Thanks.

@Yui-Song
Copy link

/lgtm

Copy link

ti-chi-bot bot commented Aug 29, 2024

@Yui-Song: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

ti-chi-bot bot commented Aug 29, 2024

@Yui-Song: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

- CPU-Avg: Average CPU utilization across all TiDB instances
- CPU-Delta: Maximum CPU utilization of all TiDB instances minus minimum CPU utilization of all TiDB instances
- CPU-Max: Maximum CPU utilization across all TiDB instances
- CPU-Quota: TiDB CPU quota
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does “TiDB CPU quota” mean as a metric? Will it change over time?
@dbsid

dashboard/dashboard-monitoring.md Show resolved Hide resolved
dashboard/dashboard-monitoring.md Show resolved Hide resolved
dashboard/dashboard-monitoring.md Outdated Show resolved Hide resolved
dashboard/dashboard-monitoring.md Outdated Show resolved Hide resolved
performance-tuning-methods.md Outdated Show resolved Hide resolved
performance-tuning-methods.md Outdated Show resolved Hide resolved
performance-tuning-methods.md Outdated Show resolved Hide resolved
performance-tuning-methods.md Outdated Show resolved Hide resolved
performance-tuning-methods.md Outdated Show resolved Hide resolved
github-actions bot pushed a commit to qiancai/pingcap-docsite-preview that referenced this pull request Sep 4, 2024
@@ -216,34 +216,92 @@ In this workload, only `ANALYZE` statements are running in the cluster:
- The total number of KV requests per second is 35.5 and the number of Cop requests per second is 9.3.
- Most of the KV processing time is spent on `Cop-internal_stats`, which indicates that the most time-consuming KV request is `Cop` from internal `ANALYZE` operations.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lilin90 lilin90 self-requested a review September 4, 2024 02:44
@lilin90
Copy link
Member

lilin90 commented Sep 4, 2024

/ok-to-test

@ti-chi-bot ti-chi-bot bot added the ok-to-test label Sep 4, 2024
Copy link
Member

@lilin90 lilin90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

ti-chi-bot bot commented Sep 10, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-09-09 09:43:59.329666384 +0000 UTC m=+263109.070090322: ☑️ agreed by lilin90.
  • 2024-09-10 02:11:11.36085407 +0000 UTC m=+322341.101278006: ☑️ agreed by qiancai.

@qiancai
Copy link
Collaborator

qiancai commented Sep 10, 2024

/retest

@qiancai
Copy link
Collaborator

qiancai commented Sep 10, 2024

/approve

Copy link

ti-chi-bot bot commented Sep 10, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiancai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Sep 10, 2024
@ti-chi-bot ti-chi-bot bot merged commit 11c7ad9 into pingcap:master Sep 10, 2024
9 checks passed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.3: #18850.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved contribution This PR is from a community contributor. lgtm needs-cherry-pick-release-8.3 Should cherry pick this PR to release-8.3 branch. ok-to-test size/L Denotes a PR that changes 100-499 lines, ignoring generated files. translation/doing This PR's assignee is translating this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

the cpu/memory and traffic in performance overview should be updated in doc
5 participants