Add input buttons #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joajfreitas
reviewed
Jun 11, 2024
| left: ctx.input(|i| i.key_down(Key::H)), | ||
| right: ctx.input(|i| i.key_down(Key::L)), | ||
| }; | ||
| self.gb.bus_mut().set_buttons(buttons); |
There was a problem hiding this comment.
is there a way we can avoid fpt-egui accessing the bus directly?
There was a problem hiding this comment.
well, either the client has to write into the gameboy, or the gameboy has to reach out and ask the client what the state of the buttons is. and it ultimately will need to touch the bus since it is a hardware register... I don't have strong opinions whether the client accesses the bus directly or indirectly. are you suggesting a method in e.g. the gameboy itself to set the buttons like self.gb.set_buttons vs self.gb.bus_mut().set_buttons or something else?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://gbdev.io/pandocs/Joypad_Input.html