🗑️Fix the stack overflow caused by a static array of String #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joajfreitas
force-pushed
the
fix_stack_overflow
branch
from
163d3c4
to
1b7a652
Compare
joajfreitas
changed the title
joajfreitas
force-pushed
the
fix_stack_overflow
branch
from
1b7a652
to
6f18e6e
Compare
diogotito
reviewed
May 26, 2024
Comment on lines
+226
to
+229
| mem: vec![0; 65536], | ||
| cartridge: Vec::new(), | ||
| bootrom: include_bytes!("../dmg0.bin"), | ||
| code_listing: [ARRAY_REPEAT_VALUE; 0xffff + 1], | ||
| code_listing: vec![ARRAY_REPEAT_VALUE; 0xffff + 1], |
There was a problem hiding this comment.
didn't know the vec! macro also supported the [x; N] syntax. Nice.
diogotito
reviewed
May 26, 2024
fpt/src/memory.rs
Outdated
| @@ -242,7 +242,7 @@ impl Memory { | |||
| &mut self.mem[range] | |||
| } | |||
|
|
|||
| pub fn code_listing(&self) -> &[Option<String>; 0xffff + 1] { | |||
| pub fn code_listing(&self) -> &Vec<Option<String>> { | |||
There was a problem hiding this comment.
btw the return type can also be &[Option<String>] because Vec<T> implements the Deref and DerefMut traits with type Target = T (which is String in our case)
joajfreitas
force-pushed
the
fix_stack_overflow
branch
from
6f18e6e
to
5b785de
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.