Fix clippy warnings

src/bitwise.rs

@@ -12,6 +12,7 @@ pub fn test_bit16<const INDEX: u8>(word: u16) -> bool {
     word & mask == mask
 }
 
+#[allow(unused)]
 pub fn get_bit8<const INDEX: u8>(word: u8) -> u8 {
     (word >> INDEX) & 0x1
 }

src/debugger.rs

@@ -63,14 +63,10 @@ impl Debugger {
         let mut gameboy = Gameboy::new();
         gameboy.set_debug(true);
 
-        let mut debugger = Debugger {
+        Debugger {
             gameboy,
             breakpoints: Vec::new(),
-        };
-
-
-
-        debugger
+        }
     }
 
     fn check(&self) -> bool {
@@ -127,6 +123,7 @@ pub struct DebuggerTextInterface<'a> {
 }
 
 impl DebuggerTextInterface<'_> {
+    #[allow(clippy::new_without_default)]
     pub fn new() -> Self {
         let debugger = Debugger::new();
         let mut lua = Lua::new();

src/memory.rs

@@ -84,7 +84,7 @@ impl Memory {
     }
 
     pub fn slice(&self, range: MemoryRange) -> &[u8] {
-        &self.mem[(range.start as usize)..(range.end as usize)]
+        &self.mem[range.start..range.end]
     }
 }
 
@@ -132,7 +132,7 @@ impl Bus {
     }
 
     pub fn clone_from_slice(&mut self, range: MemoryRange, slice: &[u8]) {
-        self.memory().mem[(range.start as usize)..(range.end as usize)].clone_from_slice(slice);
+        self.memory().mem[range.start..range.end].clone_from_slice(slice);
     }
 
     //pub fn slice(&self, range: MemoryRange) -> &[u8] {
@@ -197,9 +197,6 @@ impl Bus {
     }
 
     pub fn vram(&self) -> Vec<u8> {
-        self.memory().mem[map::VRAM]
-            .into_iter()
-            .map(|x| *x)
-            .collect()
+        self.memory().mem[map::VRAM].to_vec()
     }
 }

src/ppu.rs

@@ -1,4 +1,3 @@
-use crate::bitwise;
 use crate::memory::Bus;
 use tile::TileMap;
 
@@ -52,7 +51,6 @@ impl Ppu {
             self.tilemap = TileMap::load(&self.bus.vram());
             self.mode = dbg!(Mode::PixelTransfer);
             dbg!(self.dots_this_frame);
-            return;
         }
     }
 
@@ -67,7 +65,6 @@ impl Ppu {
         let address = WIDTH * self.bus.ly() as usize + current_pixel;
         if address >= WIDTH * HEIGHT {
             self.bus.ly();
-            self.dots_this_frame;
         }
 
         let column = address % WIDTH;
@@ -80,8 +77,6 @@ impl Ppu {
         let tile_x = column % 8;
         let tile_y = line % 8;
 
-        let tile_pixel_address = 8 * tile_y + tile_x;
-
         let tile = self.tilemap.tiles[tile_data_address as usize];
         println!("{:#02X?}", tile.pixels);
 
@@ -98,19 +93,16 @@ impl Ppu {
         if self.bus.ly() >= HEIGHT as u8 {
             self.mode = dbg!(Mode::VBlank);
             dbg!(self.dots_this_frame);
-            return;
         } else if self.dots_this_frame % 456 == 0 {
             self.mode = dbg!(Mode::OamScan);
             dbg!(self.dots_this_frame);
-            return;
         }
     }
 
     fn v_blank(&mut self) {
         if self.dots_this_frame == 0 {
             self.mode = dbg!(Mode::OamScan);
             dbg!(self.dots_this_frame);
-            return;
         }
     }
 

src/ppu/tile.rs

@@ -8,9 +8,10 @@ pub struct Tile {
 
 impl Tile {
 
+    #[allow(unused)]
     pub fn load(data: &[u8; 16]) -> Tile {
         Tile {
-            pixels: data.clone(),
+            pixels: *data,
         }
     }
     pub fn get_pixel(&self, y: usize, x: usize) -> u8{
@@ -27,7 +28,7 @@ impl fmt::Debug for Tile {
             for j in 0..8 {
                 write!(f, "{}", self.get_pixel(i, j))?;
             }
-            write!(f, "\n")?;
+            writeln!(f)?;
 
         }
         write!(f, "")
@@ -49,7 +50,7 @@ impl TileMap {
         }
     }
 
-    pub fn load(vram: &Vec<u8>) -> TileMap {
+    pub fn load(vram: &[u8]) -> TileMap {
         let mut tilemap = TileMap::default();
 
         for i in 0..384 {