Add support for processing and importing ics without UID #1082
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The general idea here makes sense to me, I mostly have one suggestion.
I would rather make the UID the hash (sha256?) of the input event itself, so that if we handle the exact same event twice, it gets the same UID, and we avoid creating a duplicate entry.
What do you think?
|
|
I'd also suggest adding a warning, so that a user importing it knows it's a bad file. |
|
Both suggestions sound good to me. I'll rework and get back to you (sadly not today, I'm out of time for the moment). Thanks for the review @WhyNotHugo and @d7415. |
viiru-
force-pushed
the
fix-import-no-uid
branch
from
185e8bc
to
375e8ea
Compare
|
I have pushed a new version that implements the suggested improvements, can you review again? |
d7415
reviewed
Aug 22, 2021
Files like this seem to be produced by all kinds of proprietary reservation systems and such. They are clearly out of spec, but since they exist I'd prefer to be able to import them without needing to manually add an UID every time. A sha256 checksum of the event is used as the UID to make it stable.
viiru-
force-pushed
the
fix-import-no-uid
branch
from
375e8ea
to
9b48eee
Compare
|
Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Files like this seem to be produced by all kinds of proprietary reservation
systems and such. They are clearly out of spec, but since they exist I'd
prefer to be able to import them without needing to manually add an UID
every time.
Another alternative would be to report an error if there is no UID and
random_uid=False, and then doing this only when random_uid=True. I'm not
sure it would be an improvement over this simpler solution, so I'll offer
this first.