Skip to content

Commit

Permalink
Rollup merge of rust-lang#55923 - Zeegomo:master, r=estebank
Browse files Browse the repository at this point in the history
reword #[test] attribute error on fn items

fix of [rust-lang#55787](rust-lang#55787)
Reworded error message from "#[test] attribute is only allowed on fn items" to "#[test] attribute is only allowed on non associated functions"
  • Loading branch information
pietroalbini committed Nov 18, 2018
2 parents 5e2ff63 + 8e13e43 commit 715d83f
Show file tree
Hide file tree
Showing 3 changed files with 40 additions and 1 deletion.
2 changes: 1 addition & 1 deletion src/libsyntax_ext/test.rs
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ pub fn expand_test_or_bench(
if let Annotatable::Item(i) = item { i }
else {
cx.parse_sess.span_diagnostic.span_fatal(item.span(),
"#[test] attribute is only allowed on fn items").raise();
"#[test] attribute is only allowed on non associated functions").raise();
};

if let ast::ItemKind::Mac(_) = item.node {
Expand Down
29 changes: 29 additions & 0 deletions src/test/ui/test-attr-non-associated-functions.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
// Copyright 2018 The Rust Project Developers. See the COPYRIGHT
// file at the top-level directory of this distribution and at
// http://rust-lang.org/COPYRIGHT.
//
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
// option. This file may not be copied, modified, or distributed
// except according to those terms.

// #[test] attribute is not allowed on associated functions or methods
// reworded error message
// compile-flags:--test

struct A {}

impl A {
#[test]
fn new() -> A { //~ ERROR #[test] attribute is only allowed on non associated functions
A {}
}
}

#[test]
fn test() {
let _ = A::new();
}

fn main() {}
10 changes: 10 additions & 0 deletions src/test/ui/test-attr-non-associated-functions.stderr
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
error: #[test] attribute is only allowed on non associated functions
--> $DIR/test-attr-non-associated-functions.rs:19:5
|
LL | / fn new() -> A { //~ ERROR #[test] attribute is only allowed on non associated functions
LL | | A {}
LL | | }
| |_____^

error: aborting due to previous error

0 comments on commit 715d83f

Please sign in to comment.