Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some explanation for self declared meta headers #6

Open
wants to merge 2 commits into
base: pico-3.0
Choose a base branch
from

Conversation

dipohl
Copy link

@dipohl dipohl commented Dec 5, 2023

Like discussed and promised in picocms/Pico#684

Copy link
Collaborator

@PhrozenByte PhrozenByte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution! 👍 Good idea, I think we should definitely add some explanation.

Please follow the overall maximum line length of 120 chars, see Social: social below for how to deal with longer lines. Instead of "i.e." please use "e.g." to properly call it an example. In general, the explanation should probably stick a little closer to that of Pico's onMetaHeaders event (it doesn't have to be the same, just more similar, because from the current explanation personally I wouldn't really understand it), see DummyPlugin::onMetaHeaders().

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants