Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

396 Disabling the save button after click #397

Merged
merged 2 commits into from
Jun 12, 2024

Conversation

dantownsend
Copy link
Member

Resolves #396

@dantownsend dantownsend added the enhancement New feature or request label Jun 11, 2024
@dantownsend dantownsend added this to In progress in Enhancements via automation Jun 11, 2024
@dantownsend
Copy link
Member Author

I just thought, we should probably change the styles of the button when it's disabled, or show a spinner or something.

Copy link
Member

@sinisaos sinisaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the slow reply. I tried your changes on a slow network and everything works. The button is disabled until the API responds. The disabled button is a different color, but if you want you can increase the contrast even more with something like this

button:disabled {
    background-color: #9fc8eb; /* or some other shade of color */
}

@dantownsend
Copy link
Member Author

dantownsend commented Jun 12, 2024

@sinisaos Thanks. I did what you suggested - tried a few different colours, but in the end I reduced the opacity of the button a bit when disabled. It's a tricky one - if the contrast is too great, it can be jarring if the network request is fast.

@dantownsend dantownsend merged commit cafbdec into master Jun 12, 2024
11 checks passed
Enhancements automation moved this from In progress to Done Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Development

Successfully merging this pull request may close these issues.

Disabling the save button after click?
2 participants