Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

File upload support #189

Merged
merged 91 commits into from
Aug 5, 2022
Merged

File upload support #189

merged 91 commits into from
Aug 5, 2022

Commits on Jul 13, 2022

  1. upload images to local storage

    @sinisaos
    sinisaos committed Jul 13, 2022
    Configuration menu
    Copy the full SHA
    52c66e0 View commit details
    Browse the repository at this point in the history

  2. empty static directory

    @sinisaos
    sinisaos committed Jul 13, 2022
    Configuration menu
    Copy the full SHA
    4acd67a View commit details
    Browse the repository at this point in the history

  3. unnecessary console.log removed

    @sinisaos
    sinisaos committed Jul 13, 2022
    Configuration menu
    Copy the full SHA
    02a90b1 View commit details
    Browse the repository at this point in the history

Commits on Jul 19, 2022

  1. add docs

    @sinisaos
    sinisaos committed Jul 19, 2022
    Configuration menu
    Copy the full SHA
    c42d59c View commit details
    Browse the repository at this point in the history

Commits on Jul 22, 2022

  1. Merge branch 'master' into image_upload

    @sinisaos
    sinisaos committed Jul 22, 2022
    Configuration menu
    Copy the full SHA
    698ad56 View commit details
    Browse the repository at this point in the history

  2. fix upload test

    @sinisaos
    sinisaos committed Jul 22, 2022
    Configuration menu
    Copy the full SHA
    2aeadb0 View commit details
    Browse the repository at this point in the history

  3. hide array add button for media columns

    @sinisaos
    sinisaos committed Jul 22, 2022
    Configuration menu
    Copy the full SHA
    cc6b7b2 View commit details
    Browse the repository at this point in the history

Commits on Jul 23, 2022

  1. media handler class

    @dantownsend
    dantownsend committed Jul 23, 2022
    Configuration menu
    Copy the full SHA
    fc1592d View commit details
    Browse the repository at this point in the history

Commits on Jul 26, 2022

  1. flesh out local media storage

    @dantownsend
    dantownsend committed Jul 26, 2022
    Configuration menu
    Copy the full SHA
    7057d1b View commit details
    Browse the repository at this point in the history

  2. added tests for generate_file_id

    @dantownsend
    dantownsend committed Jul 26, 2022
    Configuration menu
    Copy the full SHA
    39190f0 View commit details
    Browse the repository at this point in the history

Commits on Jul 28, 2022

  1. fleshed out LocalMediaStorage

    @dantownsend
    dantownsend committed Jul 28, 2022
    Configuration menu
    Copy the full SHA
    d386f68 View commit details
    Browse the repository at this point in the history

  2. remove print statement

    @dantownsend
    dantownsend committed Jul 28, 2022
    Configuration menu
    Copy the full SHA
    9a90c1a View commit details
    Browse the repository at this point in the history

  3. media_columns is now a dict

    @dantownsend
    dantownsend committed Jul 28, 2022
    Configuration menu
    Copy the full SHA
    fb9b192 View commit details
    Browse the repository at this point in the history

Commits on Jul 29, 2022

  1. show error message is file posting fails

    @dantownsend
    dantownsend committed Jul 29, 2022
    Configuration menu
    Copy the full SHA
    6a6a3a4 View commit details
    Browse the repository at this point in the history

  2. return any ValueErrors as HTTPException

    @dantownsend
    dantownsend committed Jul 29, 2022
    Configuration menu
    Copy the full SHA
    be05dd8 View commit details
    Browse the repository at this point in the history

  3. add webp as an allowed file extension

    @dantownsend
    dantownsend committed Jul 29, 2022
    Configuration menu
    Copy the full SHA
    ed4c20f View commit details
    Browse the repository at this point in the history

  4. improve error message for disallowed file name characters

    @dantownsend
    dantownsend committed Jul 29, 2022
    Configuration menu
    Copy the full SHA
    48af429 View commit details
    Browse the repository at this point in the history

  5. fix bug in file name truncation

    @dantownsend
    dantownsend committed Jul 29, 2022
    Configuration menu
    Copy the full SHA
    95e6f0a View commit details
    Browse the repository at this point in the history

  6. fix tests

    @dantownsend
    dantownsend committed Jul 29, 2022
    Configuration menu
    Copy the full SHA
    b3eeb43 View commit details
    Browse the repository at this point in the history

Commits on Jul 30, 2022

  1. added generate_file_url endpoint

    @dantownsend
    dantownsend committed Jul 30, 2022
    Configuration menu
    Copy the full SHA
    7848d10 View commit details
    Browse the repository at this point in the history

  2. added test for generating file URL endpoint

    @dantownsend
    dantownsend committed Jul 30, 2022
    Configuration menu
    Copy the full SHA
    3a53949 View commit details
    Browse the repository at this point in the history

  3. broke up ALLOWED_EXTENSIONS 

    this makes it easier for users to pick and mix them
    @dantownsend
    dantownsend committed Jul 30, 2022
    Configuration menu
    Copy the full SHA
    d862672 View commit details
    Browse the repository at this point in the history

  4. added MediaViewer component

    @dantownsend
    dantownsend committed Jul 30, 2022
    Configuration menu
    Copy the full SHA
    28b9343 View commit details
    Browse the repository at this point in the history

  5. arrays of images now works in RowListing

    @dantownsend
    dantownsend committed Jul 30, 2022
    Configuration menu
    Copy the full SHA
    1882a84 View commit details
    Browse the repository at this point in the history

  6. detect if media is an image in MediaViewer

    @dantownsend
    dantownsend committed Jul 30, 2022
    Configuration menu
    Copy the full SHA
    a7b571d View commit details
    Browse the repository at this point in the history

  7. added support for video playback in MediaViewer

    @dantownsend
    dantownsend committed Jul 30, 2022
    Configuration menu
    Copy the full SHA
    fc8a1ae View commit details
    Browse the repository at this point in the history

  8. add example_media folder to git - needed for tests

    @dantownsend
    dantownsend committed Jul 30, 2022
    Configuration menu
    Copy the full SHA
    324502f View commit details
    Browse the repository at this point in the history

Commits on Jul 31, 2022

  1. added audio playback support to MediaViewer

    @dantownsend
    dantownsend committed Jul 31, 2022
    Configuration menu
    Copy the full SHA
    6d318de View commit details
    Browse the repository at this point in the history

  2. don't show media viewer content until URL has been fetched 

    It stops Vue from showing a warning in the console
    @dantownsend
    dantownsend committed Jul 31, 2022
    Configuration menu
    Copy the full SHA
    26603b2 View commit details
    Browse the repository at this point in the history

  3. slightly smaller text for add button in array widget

    @dantownsend
    dantownsend committed Jul 31, 2022
    Configuration menu
    Copy the full SHA
    8d0b5b1 View commit details
    Browse the repository at this point in the history

  4. started integrating MediaViewer into row detail page

    @dantownsend
    dantownsend committed Jul 31, 2022
    Configuration menu
    Copy the full SHA
    426494d View commit details
    Browse the repository at this point in the history

  5. add PDF support to MediaViewer

    @dantownsend
    dantownsend committed Jul 31, 2022
    Configuration menu
    Copy the full SHA
    396c932 View commit details
    Browse the repository at this point in the history

  6. improve image and video containers on MediaViewer 

    * The images were backgrounds, so was unable to do a right click, and open in new tab.
* The video wasn't shrinking when the window height was changed.
    @dantownsend
    dantownsend committed Jul 31, 2022
    Configuration menu
    Copy the full SHA
    41efa53 View commit details
    Browse the repository at this point in the history

  7. improved loading indicator in MediaViewer 

    * It's now centred vertically and horizontally.
* Added a loading spinner
    @dantownsend
    dantownsend committed Jul 31, 2022
    Configuration menu
    Copy the full SHA
    0a39eb9 View commit details
    Browse the repository at this point in the history

  8. remove unused import

    @dantownsend
    dantownsend committed Jul 31, 2022
    Configuration menu
    Copy the full SHA
    3f95605 View commit details
    Browse the repository at this point in the history

Commits on Aug 1, 2022

  1. remove test files

    @dantownsend
    dantownsend committed Aug 1, 2022
    Configuration menu
    Copy the full SHA
    cabe139 View commit details
    Browse the repository at this point in the history

  2. don't allow double periods in the file name

    @dantownsend
    dantownsend committed Aug 1, 2022
    Configuration menu
    Copy the full SHA
    aeefdb4 View commit details
    Browse the repository at this point in the history

  3. add s3 as optional requirements

    @dantownsend
    dantownsend committed Aug 1, 2022
    Configuration menu
    Copy the full SHA
    71fc1c1 View commit details
    Browse the repository at this point in the history

  4. add requirements file for faker

    @dantownsend
    dantownsend committed Aug 1, 2022
    Configuration menu
    Copy the full SHA
    b0ca360 View commit details
    Browse the repository at this point in the history

  5. removed media_url argument from LocalMediaStorage

    @dantownsend
    dantownsend committed Aug 1, 2022
    Configuration menu
    Copy the full SHA
    d0d7aaa View commit details
    Browse the repository at this point in the history

  6. add missing import

    @dantownsend
    dantownsend committed Aug 1, 2022
    Configuration menu
    Copy the full SHA
    47a3fa8 View commit details
    Browse the repository at this point in the history

  7. added first version of S3MediaStorage

    @dantownsend
    dantownsend committed Aug 1, 2022
    Configuration menu
    Copy the full SHA
    77e8a61 View commit details
    Browse the repository at this point in the history

  8. put S3MediaStorage and LocalMediaStorage in separate files

    @dantownsend
    dantownsend committed Aug 1, 2022
    Configuration menu
    Copy the full SHA
    d77cbd3 View commit details
    Browse the repository at this point in the history

  9. allow lower coverage for now

    @dantownsend
    dantownsend committed Aug 1, 2022
    Configuration menu
    Copy the full SHA
    8bad1a4 View commit details
    Browse the repository at this point in the history

  10. moved files into new folder structure

    @dantownsend
    dantownsend committed Aug 1, 2022
    Configuration menu
    Copy the full SHA
    236b4a5 View commit details
    Browse the repository at this point in the history

Commits on Aug 2, 2022

  1. added tests for S3

    @dantownsend
    dantownsend committed Aug 2, 2022
    Configuration menu
    Copy the full SHA
    e784d48 View commit details
    Browse the repository at this point in the history

  2. use connection kwargs

    @dantownsend
    dantownsend committed Aug 2, 2022
    Configuration menu
    Copy the full SHA
    11b61d3 View commit details
    Browse the repository at this point in the history

  3. S3 can optionally be used in the example app

    @dantownsend
    dantownsend committed Aug 2, 2022
    Configuration menu
    Copy the full SHA
    b288a92 View commit details
    Browse the repository at this point in the history

  4. mention that S3 usage in example.py is just for Movie.poster

    @dantownsend
    dantownsend committed Aug 2, 2022
    Configuration menu
    Copy the full SHA
    50ce8b3 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'master' into 109-media-handlers

    @dantownsend
    dantownsend committed Aug 2, 2022
    Configuration menu
    Copy the full SHA
    7c94ce8 View commit details
    Browse the repository at this point in the history

  6. MediaStorage now accepts a column arg 

    By `MediaStorage` knowing which column is belong to, we can work out which files are no longer being used.
    @dantownsend
    dantownsend committed Aug 2, 2022
    Configuration menu
    Copy the full SHA
    3f17007 View commit details
    Browse the repository at this point in the history

  7. added helper methods to media storage classes 

    This makes it easier for people to access the files stored by piccolo_admin, and use them within their own apps. They can also easily remove any files which are no longer needed.
    @dantownsend
    dantownsend committed Aug 2, 2022
    Configuration menu
    Copy the full SHA
    4d35189 View commit details
    Browse the repository at this point in the history

  8. fix lgtm warning

    @dantownsend
    dantownsend committed Aug 2, 2022
    Configuration menu
    Copy the full SHA
    a197c8a View commit details
    Browse the repository at this point in the history

  9. reduce coverage required for now

    @dantownsend
    dantownsend committed Aug 2, 2022
    Configuration menu
    Copy the full SHA
    6801ac0 View commit details
    Browse the repository at this point in the history

  10. ignore coverage for TYPE_CHECKING imports

    @dantownsend
    dantownsend committed Aug 2, 2022
    Configuration menu
    Copy the full SHA
    9b18574 View commit details
    Browse the repository at this point in the history

  11. add test to make sure LocalMediaStorage creates the media folder is… 

    … it doesn't exist
    @dantownsend
    dantownsend committed Aug 2, 2022
    Configuration menu
    Copy the full SHA
    08631f2 View commit details
    Browse the repository at this point in the history

  12. add test for LocalMediaStorage.get_file

    @dantownsend
    dantownsend committed Aug 2, 2022
    Configuration menu
    Copy the full SHA
    53f8084 View commit details
    Browse the repository at this point in the history

  13. remove unused import

    @dantownsend
    dantownsend committed Aug 2, 2022
    Configuration menu
    Copy the full SHA
    2abafbd View commit details
    Browse the repository at this point in the history

  14. close file at end of test

    @dantownsend
    dantownsend committed Aug 2, 2022
    Configuration menu
    Copy the full SHA
    6470ea6 View commit details
    Browse the repository at this point in the history

  15. added test for LocalMediaStorage.bulk_delete

    @dantownsend
    dantownsend committed Aug 2, 2022
    Configuration menu
    Copy the full SHA
    bd426e7 View commit details
    Browse the repository at this point in the history

  16. make sure duplicate file names raises an error

    @dantownsend
    dantownsend committed Aug 2, 2022
    Configuration menu
    Copy the full SHA
    4b59f09 View commit details
    Browse the repository at this point in the history

  17. improve coverage for S3MediaStorage

    @dantownsend
    dantownsend committed Aug 2, 2022
    Configuration menu
    Copy the full SHA
    ee33479 View commit details
    Browse the repository at this point in the history

  18. more tests for S3MediaStorate - getting and listing files

    @dantownsend
    dantownsend committed Aug 2, 2022
    Configuration menu
    Copy the full SHA
    4efd48d View commit details
    Browse the repository at this point in the history

  19. added test for S3MediaStorage.delete_file

    @dantownsend
    dantownsend committed Aug 2, 2022
    Configuration menu
    Copy the full SHA
    b9ca34f View commit details
    Browse the repository at this point in the history

  20. add tests for S3MediaStorage.bulk_delete_files

    @dantownsend
    dantownsend committed Aug 2, 2022
    Configuration menu
    Copy the full SHA
    62468aa View commit details
    Browse the repository at this point in the history

  21. exclude abstract methods from code coverage

    @dantownsend
    dantownsend committed Aug 2, 2022
    Configuration menu
    Copy the full SHA
    f57b7bd View commit details
    Browse the repository at this point in the history

Commits on Aug 3, 2022

  1. fix nginx syntax error

    @dantownsend
    dantownsend committed Aug 3, 2022
    Configuration menu
    Copy the full SHA
    c2a56de View commit details
    Browse the repository at this point in the history

  2. added test for MediaStorage.get_file_keys_from_db

    @dantownsend
    dantownsend committed Aug 3, 2022
    Configuration menu
    Copy the full SHA
    e768df1 View commit details
    Browse the repository at this point in the history

  3. add tests for allowed column types

    @dantownsend
    dantownsend committed Aug 3, 2022
    Configuration menu
    Copy the full SHA
    4abedbb View commit details
    Browse the repository at this point in the history

  4. add test for files with no extension

    @dantownsend
    dantownsend committed Aug 3, 2022
    Configuration menu
    Copy the full SHA
    ce2805a View commit details
    Browse the repository at this point in the history

  5. added test for MediaStorage.delete_unused_files

    @dantownsend
    dantownsend committed Aug 3, 2022
    Configuration menu
    Copy the full SHA
    1fb60e2 View commit details
    Browse the repository at this point in the history

  6. increase minimum coverage

    @dantownsend
    dantownsend committed Aug 3, 2022
    Configuration menu
    Copy the full SHA
    e8f1085 View commit details
    Browse the repository at this point in the history

  7. updated docs

    @dantownsend
    dantownsend committed Aug 3, 2022
    Configuration menu
    Copy the full SHA
    8824802 View commit details
    Browse the repository at this point in the history

  8. added images showing the UI for different file types

    @dantownsend
    dantownsend committed Aug 3, 2022
    Configuration menu
    Copy the full SHA
    a7bb2ac View commit details
    Browse the repository at this point in the history

  9. adds docs for IMAGE_EXTENSIONS etc

    @dantownsend
    dantownsend committed Aug 3, 2022
    Configuration menu
    Copy the full SHA
    3ac1f77 View commit details
    Browse the repository at this point in the history

  10. fix typos in the docs

    @dantownsend
    dantownsend committed Aug 3, 2022
    Configuration menu
    Copy the full SHA
    da06fb1 View commit details
    Browse the repository at this point in the history

  11. add links to 'cleaning up files'

    @dantownsend
    dantownsend committed Aug 3, 2022
    Configuration menu
    Copy the full SHA
    eb63492 View commit details
    Browse the repository at this point in the history

  12. file_id -> file_key 

    Half of the codebase used `file_id`, and half of it used `file_key`. It has now been standardised as `file_key`.
    @dantownsend
    dantownsend committed Aug 3, 2022
    Configuration menu
    Copy the full SHA
    e098c31 View commit details
    Browse the repository at this point in the history

Commits on Aug 4, 2022

  1. added support for S3 folders

    @dantownsend
    dantownsend committed Aug 4, 2022
    Configuration menu
    Copy the full SHA
    9eae605 View commit details
    Browse the repository at this point in the history

  2. update docs about keeping files in separate S3 buckets

    @dantownsend
    dantownsend committed Aug 4, 2022
    Configuration menu
    Copy the full SHA
    d0f60ee View commit details
    Browse the repository at this point in the history

  3. fix error with unused variable

    @dantownsend
    dantownsend committed Aug 4, 2022
    Configuration menu
    Copy the full SHA
    e2e51fb View commit details
    Browse the repository at this point in the history

  4. raise an error is media storage is misconfigured

    @dantownsend
    dantownsend committed Aug 4, 2022
    Configuration menu
    Copy the full SHA
    9827a44 View commit details
    Browse the repository at this point in the history

  5. fix lgtm warnings

    @dantownsend
    dantownsend committed Aug 4, 2022
    Configuration menu
    Copy the full SHA
    5ebfb0a View commit details
    Browse the repository at this point in the history

  6. moved logic for file name verification into separate method 

    This makes it easier for people to override `generate_file_key` if they want to.
    @dantownsend
    dantownsend committed Aug 4, 2022
    Configuration menu
    Copy the full SHA
    bf459bd View commit details
    Browse the repository at this point in the history

  7. moved MediaStorage to api reference page 

    It was a bit overwhelming having it in the main media storage page. Most people don't have to worry about it.
    @dantownsend
    dantownsend committed Aug 4, 2022
    Configuration menu
    Copy the full SHA
    fa914f7 View commit details
    Browse the repository at this point in the history

  8. add Sphinx viewcode extension

    @dantownsend
    dantownsend committed Aug 4, 2022
    Configuration menu
    Copy the full SHA
    fb42eea View commit details
    Browse the repository at this point in the history

  9. add extra features to homepage of docs

    @dantownsend
    dantownsend committed Aug 4, 2022
    Configuration menu
    Copy the full SHA
    7b86545 View commit details
    Browse the repository at this point in the history

  10. added LoadingOverlay component 

    Provides some visual feedback when uploading a file.
    @dantownsend
    dantownsend committed Aug 4, 2022
    Configuration menu
    Copy the full SHA
    b801edd View commit details
    Browse the repository at this point in the history

  11. make code in example.py consistent with docs

    @dantownsend
    dantownsend committed Aug 4, 2022
    Configuration menu
    Copy the full SHA
    6c352fc View commit details
    Browse the repository at this point in the history

  12. fix test

    @dantownsend
    dantownsend committed Aug 4, 2022
    Configuration menu
    Copy the full SHA
    7a273f4 View commit details
    Browse the repository at this point in the history

Commits on Aug 5, 2022

  1. make array widget work

    @dantownsend
    dantownsend committed Aug 5, 2022
    Configuration menu
    Copy the full SHA
    60ce88e View commit details
    Browse the repository at this point in the history