Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactored modules and reexports #89

Merged
merged 3 commits into from
Sep 21, 2018
Merged

Refactored modules and reexports #89

merged 3 commits into from
Sep 21, 2018

Conversation

phsym
Copy link
Owner

@phsym phsym commented Sep 21, 2018

  • Reexported types used from csv crate
  • Moved CSV stuff in dedicated module
  • Reexport cell::Cell and row::Row into crate's root
  • cell and row modules are now private

@phsym phsym added this to the v0.8.0 milestone Sep 21, 2018
@phsym phsym self-assigned this Sep 21, 2018
@codecov
Copy link

codecov bot commented Sep 21, 2018

Codecov Report

Merging #89 into master will decrease coverage by 0.58%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #89      +/-   ##
==========================================
- Coverage   84.42%   83.83%   -0.59%     
==========================================
  Files           5        5              
  Lines        1220     1157      -63     
==========================================
- Hits         1030      970      -60     
+ Misses        190      187       -3
Impacted Files Coverage Δ
src/cell.rs 85.58% <ø> (ø) ⬆️
src/row.rs 90.96% <ø> (ø) ⬆️
src/lib.rs 85.07% <ø> (-1.26%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 18ffe50...dee6df4. Read the comment docs.

@phsym phsym merged commit 0291416 into master Sep 21, 2018
@phsym phsym deleted the refactor_mods branch September 21, 2018 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant