Fixed cell width issues when using ANSI color codes. #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds a `utils::display_width` function, which is just a wrapper
around `UnicodeWidthStr::width` which also takes ANSI color codes into account.
This is required when creating cells from strings which are already colored
using ANSI color codes (instead of coloring the cells using styles). Since
color codes are of the form \u{1b}[ ... m, but UnicodeWidthStr::width only
takes the first \u{1b} into account, this would create cell width issues.
phsym
reviewed
Aug 9, 2018
| @@ -75,6 +75,36 @@ pub fn print_align<T: Write + ?Sized>(out: &mut T, | |||
| Ok(()) | |||
| } | |||
|
|
|||
| /// Return the display width of a unicode string. | |||
| /// This functions takes ANSI-escaped color codes into account. | |||
| pub fn display_width(text: &str) -> usize { | |||
There was a problem hiding this comment.
Would be even better with some tests
phsym
approved these changes
Aug 9, 2018
|
Thanks a lot for that. Again, sorry for the delay. I've been quite busy over the past months |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
utils::display_widthfunction, which is just a wrapper aroundUnicodeWidthStr::widthwhich also takes ANSI color codes into account.This is required when creating cells from strings which are already colored using ANSI color codes (instead of coloring the cells using styles). Since color codes are of the form
\u{1b}[ ... m, but UnicodeWidthStr::width only takes the first\u{1b}into account, this would create cell width issues.This solves issue #46.