Repair PhpParser\Node\Stmt\Class_::isAnonymous() #3343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tscni
force-pushed
the
fix/class-is-anonymous
branch
from
5c723eb
to
b8a841b
Compare
tscni
commented
Aug 22, 2024
| @@ -27,10 +27,20 @@ public function enterNode(Node $node): ?Node | |||
| return null; | |||
| } | |||
|
|
|||
| $node->setAttribute(self::ATTRIBUTE_ANONYMOUS_CLASS, true); | |||
There was a problem hiding this comment.
In theory this isn't covered by the backward compatibility promise, right?
Even so, the removal of this would cause some breakages (see e.g. mglaman/phpstan-drupal#195)
There was a problem hiding this comment.
Let's keep the attribute but don't use it ourselves anywhere anymore.
There was a problem hiding this comment.
Done. I opted against keeping the constant since it's not meant to be reused.
ondrejmirtes
requested changes
Aug 23, 2024
| @@ -27,10 +27,20 @@ public function enterNode(Node $node): ?Node | |||
| return null; | |||
| } | |||
|
|
|||
| $node->setAttribute(self::ATTRIBUTE_ANONYMOUS_CLASS, true); | |||
There was a problem hiding this comment.
Let's keep the attribute but don't use it ourselves anywhere anymore.
|
Thank you! Btw I wouldn't bother PHP-Parser with this, it's a niche edge case we've already solved, no need to change the underlying library. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As proposed here: #3328 (comment)